Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle embedded subtitle metadata (label, language) #6189

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Handle embedded subtitle metadata (label, language) #6189

wants to merge 3 commits into from

Conversation

masaball
Copy link
Contributor

@masaball masaball commented Feb 6, 2025

Related issue: #6147

Wait to review until samvera-labs/active_encode/pull/143 has been merged

@masaball masaball force-pushed the subtitle_metadata_extraction branch from f0ea667 to e054cfe Compare February 13, 2025 20:09
@masaball masaball marked this pull request as ready for review February 13, 2025 20:35
cjcolvar
cjcolvar reviewed Feb 17, 2025
View reviewed changes
Copy link
Member

@cjcolvar cjcolvar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like where this is going. Expanding on LanguageTerm feels like it could be useful in the future beyond this PR.

app/models/language_term.rb Outdated Show resolved Hide resolved
app/models/watched_encode.rb Outdated Show resolved Hide resolved
@masaball masaball force-pushed the subtitle_metadata_extraction branch from e054cfe to b910c7f Compare February 19, 2025 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjcolvar cjcolvar cjcolvar left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@masaball @cjcolvar