Download hosted files to tmp and move to dropbox when uploading #6159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Interntet host files such as google drive or sharepoint were being downloaded multiple times during processing. By creating a tempfile and moving it into the dropbox, this should remove or at least minimize excess downloads.
|
Failing test is an unrelated flaky test for playlists |
cjcolvar
reviewed
Jan 8, 2025
This commit also includes some tightening up of the test suite and removing an unneeded `File#rewind` call from `FileLocator#local_file`.
cjcolvar
previously approved these changes
Jan 8, 2025
cjcolvar
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #6129 (may also take care of #6152 but that needs to be more thoroughly tested)
Internet hosted files such as google drive or sharepoint were being downloaded multiple times during processing. By creating a tempfile and moving it into the dropbox, this should remove or at least minimize excess downloads.