Additional improvements over #49 #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't think the application is using this for anything yet, but this is supposed to be secret.
This already runs as root. See <https://docs.aws.amazon.com/AWSEC2/\ latest/UserGuide/user-data.html#user-data-shell-scripts>.
This was using a nonexistent device for the Solr data. An alias to the correct device is declared as the 'device_name' attribute on 'aws_ebs_volume.solr_data', so this uses that instead. This also makes the mountpoint unwriteable if it can't be mounted, so Solr will fail rather than writing its data to the EC2 instance's root filesystem.
The VM should be rebuilt when its configuration changes or when there's a newer VM image. Also, since the "user data" script isn't idempotent, the VM should be rebuilt rather than restarted when the script changes. Lowering the TTL on the VM's A record, which is only used for administrative access, will make it available faster without imposing a burden on DNS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based upon the great work in #49, I made a few more changes:
With the changes in #49 and this PR, one should be able to edit the avalon version (branch or commit) or avalon-docker version (branch or commit) via config and
terraform applyto upgrade! This is a huge step forward from before where the terraform was essentially a bootstrapping process and upgrades had to be done manually in the EC2 instance or CodeBuild.