Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[client] Fix test generation overriding main components #559

Merged
merged 4 commits into from
Jan 28, 2025

Conversation

SentryMan
Copy link
Collaborator

@SentryMan SentryMan commented Jan 27, 2025

It seems that generating a client during src/test compilation causes clients generated in src/main to be undetected during tests.

This PR makes it so that the main src/main/META-INF/services are also detected during test compilation

@SentryMan SentryMan added the bug Something isn't working label Jan 27, 2025
@SentryMan SentryMan self-assigned this Jan 27, 2025
@SentryMan SentryMan added this to the 3.0 milestone Jan 27, 2025
@SentryMan SentryMan enabled auto-merge (squash) January 27, 2025 22:02
@SentryMan SentryMan requested a review from rbygrave January 27, 2025 22:20
@SentryMan SentryMan changed the title [client] Fix test client ruining main detection [client] Fix test generation overriding main components Jan 28, 2025
@SentryMan SentryMan merged commit 4ab81db into avaje:master Jan 28, 2025
6 checks passed
@SentryMan SentryMan deleted the test-compilation branch January 28, 2025 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants