Layout rework #224
Open
Layout rework #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PMunch
commented
Feb 6, 2024
|
|
||
| for client in this.taggedClients.clients: | ||
| if client.borderWidth != 0 or this.monitorSettings.layoutSettings.outerGap > 0: | ||
| client.borderWidth = this.windowSettings.borderWidth |
There was a problem hiding this comment.
This was just done to make things pass. Probably not quite correct, but I'm not entirely sure what this does.
PMunch
commented
Feb 6, 2024
The bug requiring monitor section to be present or it would crash with a cryptic message.
|
Tests are green now. Apart from the comment above I don't think there's anything I've missed now. |
|
Looked into implementing my new layout now. It seems like I might want to add a |
Allow width/height and x/y to be set even when not in floating mode, my layout only responds to width/height at the moment, but maybe someone else will need this. Otherwise it's just moving bits and pieces around.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit moves all the layout logic and settings out from various modules and into the "masterstacklayout" module. With these changes it should be much easier to add new layouts.
There are still a couple actions like "moveWindowNext" which I guess technically might be said to belong to the "masterstacklayout" so it's possible that I might have to make some further changes in order to make new layouts work. But I believe this should be enough.