-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ACP 99 reference implementation improvements #702
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardpringle
previously approved these changes
Jan 18, 2025
geoff-vball
previously approved these changes
Jan 20, 2025
iansuvak
previously approved these changes
Jan 21, 2025
2 tasks
bernard-avalabs
previously approved these changes
Jan 23, 2025
The base branch was changed.
iansuvak
approved these changes
Jan 31, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-approving, changes since last approval are regenerated abi-bindings post merge.
geoff-vball
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Improves upon #700 by making the following changes to align the rest of the validator manager contracts with ACP-99:
IValidatorManager
, asACP99Manager
captures the functionality that validator managers must implement.initializeValidatorRegistration
,initializeDelegatorRegistration
, etc methods toinitiate
to reflect the naming convention used in ACP-99. These methods initiate a process; they do not initialize any data. Note thatinitializeValidatorSet
is not renamed, since this method does perform initialization.PoSValidatorManager
to conform to the ACP-99 naming conventions for validator management.ValidatorRegistrationInput
in favor of providing the fields as standalone arguments. This matches ACP-99, as well as reduces the contract size.How this works
See above
How this was tested
CI
How is this documented
The same changes above apply to the README