Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACP 99 reference implementation improvements #702

Merged
merged 8 commits into from
Jan 31, 2025

Conversation

cam-schultz
Copy link
Contributor

@cam-schultz cam-schultz commented Jan 15, 2025

Why this should be merged

Improves upon #700 by making the following changes to align the rest of the validator manager contracts with ACP-99:

  • Removes IValidatorManager, as ACP99Manager captures the functionality that validator managers must implement.
  • Rename initializeValidatorRegistration, initializeDelegatorRegistration, etc methods to initiate to reflect the naming convention used in ACP-99. These methods initiate a process; they do not initialize any data. Note that initializeValidatorSet is not renamed, since this method does perform initialization.
  • Rename delegator management methods in PoSValidatorManager to conform to the ACP-99 naming conventions for validator management.
  • Remove ValidatorRegistrationInput in favor of providing the fields as standalone arguments. This matches ACP-99, as well as reduces the contract size.

How this works

See above

How this was tested

CI

How is this documented

The same changes above apply to the README

@cam-schultz cam-schultz marked this pull request as ready for review January 16, 2025 15:41
@cam-schultz cam-schultz requested a review from a team as a code owner January 16, 2025 15:41
richardpringle
richardpringle previously approved these changes Jan 18, 2025
geoff-vball
geoff-vball previously approved these changes Jan 20, 2025
iansuvak
iansuvak previously approved these changes Jan 21, 2025
Base automatically changed from acp-99-reference-impl to main January 31, 2025 20:51
@cam-schultz cam-schultz dismissed stale reviews from bernard-avalabs, iansuvak, geoff-vball, and richardpringle January 31, 2025 20:51

The base branch was changed.

Copy link
Contributor

@iansuvak iansuvak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approving, changes since last approval are regenerated abi-bindings post merge.

@cam-schultz cam-schultz merged commit 028c07c into main Jan 31, 2025
17 checks passed
@cam-schultz cam-schultz deleted the acp-99-reference-impl-improvements branch January 31, 2025 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants