Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(core/rawdb): use libevm core/rawdb #772

Merged
merged 29 commits into from
Mar 5, 2025
Merged

Conversation

qdm12
Copy link
Collaborator

@qdm12 qdm12 commented Jan 29, 2025

Why this should be merged

Gets rid of most of core/rawdb geth code using libevm.

You might want to review the PR commit by commit, given historically, work for this PR was done as:

  • First stage (see commits) was to get code as close to geth code (libevm main branch) as possible.
  • Second stage was identifying the differences: ReadBlock's use of extras and InspectDatabase
  • Third stage was implement libevm hooks and other change and use libevm core/rawdb (last commit)

How this works

  • Move our own code to _ext.go files
  • Import symbols from libevm in imports.go
  • Use Block and Body hooks previously implemented

How this was tested

CI passing

Need to be documented?

No

Need to update RELEASES.md?

No

@qdm12 qdm12 force-pushed the qdm12/core/rawdb-geth-closer branch 3 times, most recently from a12a415 to f9ba5bf Compare January 31, 2025 14:59
@qdm12 qdm12 changed the title chore(core/rawdb): make code closer to geth code chore(core/rawdb): use libevm core/rawdb for most things Jan 31, 2025
@qdm12 qdm12 changed the title chore(core/rawdb): use libevm core/rawdb for most things chore(core/rawdb): use libevm core/rawdb Jan 31, 2025
@qdm12 qdm12 changed the title chore(core/rawdb): use libevm core/rawdb chore(core/rawdb): use libevm core/rawdb (8) Feb 14, 2025
@qdm12 qdm12 force-pushed the qdm12/core/rawdb-geth-closer branch from f9ba5bf to 31eee9f Compare February 14, 2025 14:10
@qdm12 qdm12 changed the base branch from qdm12/core/types/block-libevm to qdm12/core/rawdb/inspect-database February 14, 2025 14:10
@qdm12 qdm12 force-pushed the qdm12/core/rawdb/inspect-database branch from 710c622 to 0b398d6 Compare February 14, 2025 14:20
@qdm12 qdm12 force-pushed the qdm12/core/rawdb-geth-closer branch from 31eee9f to 856fd65 Compare February 14, 2025 14:20
@qdm12 qdm12 changed the title chore(core/rawdb): use libevm core/rawdb (8) chore(core/rawdb): use libevm core/rawdb (9) Feb 19, 2025
@qdm12 qdm12 mentioned this pull request Feb 21, 2025
1 task
@qdm12 qdm12 force-pushed the qdm12/core/rawdb/inspect-database branch from 0b398d6 to 67a9d12 Compare February 28, 2025 18:47
@qdm12 qdm12 force-pushed the qdm12/core/rawdb-geth-closer branch from 0f52367 to 30f360f Compare February 28, 2025 19:18
@qdm12 qdm12 force-pushed the qdm12/core/rawdb/inspect-database branch from 7fe0168 to 26ccd5d Compare February 28, 2025 19:20
@qdm12 qdm12 force-pushed the qdm12/core/rawdb-geth-closer branch from 30f360f to 17ec6d1 Compare February 28, 2025 19:37
Base automatically changed from qdm12/core/rawdb/inspect-database to libevm March 2, 2025 20:01
@qdm12 qdm12 force-pushed the qdm12/core/rawdb-geth-closer branch from 0db0dcf to 7bcd7d9 Compare March 2, 2025 20:15
@qdm12 qdm12 force-pushed the qdm12/core/rawdb-geth-closer branch from 7bcd7d9 to 975281b Compare March 2, 2025 20:23
@qdm12 qdm12 marked this pull request as ready for review March 2, 2025 20:48
@qdm12 qdm12 requested review from ceyonur and a team as code owners March 2, 2025 20:48
@qdm12
Copy link
Collaborator Author

qdm12 commented Mar 2, 2025

This PR is further improved/cleaned up with subsequent #851

@qdm12 qdm12 requested review from ceyonur and darioush March 3, 2025 10:16
@qdm12 qdm12 changed the title chore(core/rawdb): use libevm core/rawdb (9) chore(core/rawdb): use libevm core/rawdb Mar 3, 2025
@qdm12 qdm12 requested a review from ARR4N March 4, 2025 13:18
@qdm12 qdm12 merged commit 73228ba into libevm Mar 5, 2025
6 checks passed
@qdm12 qdm12 deleted the qdm12/core/rawdb-geth-closer branch March 5, 2025 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants