Update acceptor tip before sending chain events to subscribers #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darioush
approved these changes
Nov 16, 2023
ceyonur
approved these changes
Nov 17, 2023
joshua-kim
added a commit
that referenced
this pull request
Nov 21, 2023
commit c609216 Author: Ceyhun Onur <[email protected]> Date: Fri Nov 17 17:48:21 2023 +0300 add context to network handlers (#383) commit c97fe2f Author: aaronbuchwald <[email protected]> Date: Fri Nov 17 04:42:41 2023 -0500 Update acceptor tip before sending chain events to subscribers (#392) commit 7a3d26b Author: Joshua Kim <[email protected]> Date: Wed Nov 15 17:30:52 2023 -0500 Add loggers to SDK Handlers (#373) commit 7cefd0f Author: Ceyhun Onur <[email protected]> Date: Mon Nov 13 23:40:37 2023 +0300 remove specific folders (#385) commit ce93f8e Author: xiaolou86 <[email protected]> Date: Thu Nov 9 07:52:22 2023 +0800 docs: fix typo (#380) commit bf20517 Author: Darioush Jalali <[email protected]> Date: Tue Nov 7 11:17:08 2023 -0800 align rpc/types.go with upstream (#381) * ethclient: restore special casing in ToBlockNumArg * add explicit SafeBlockNumber * wspace * add string commit 740c60e Author: Anusha <[email protected]> Date: Fri Nov 3 14:30:36 2023 -0700 remove extra err check (#378) commit 3867e0f Author: Darioush Jalali <[email protected]> Date: Fri Nov 3 13:48:10 2023 -0700 params: fix log + errors for Cancun timestamp (#368) Co-authored-by: aaronbuchwald <[email protected]> commit a3726f1 Author: aaronbuchwald <[email protected]> Date: Fri Nov 3 12:04:45 2023 -0400 Start v0.12.8 release (#374) Signed-off-by: Joshua Kim <[email protected]>
darioush
added a commit
that referenced
this pull request
Apr 25, 2024
… (#1060) Co-authored-by: aaronbuchwald <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
This PR moves updating the
acceptorTipto before sending events to any subscribers. This ensures that any client that relies on these events will observe that any subsequent request observes a state consistent with the transactions/block being marked as accepted.How this was tested
CI