Update precompile setup for warp #390
Conversation
| // - Enabling or disabling precompiles as network upgrades. | ||
| type UpgradeConfig struct { | ||
| // Config for enabling and disabling precompiles as network upgrades. | ||
| PrecompileUpgrades []PrecompileUpgrade `json:"precompileUpgrades,omitempty"` |
There was a problem hiding this comment.
do we need this? Isn't warp going to be activated with DUpgrade itself?
There was a problem hiding this comment.
Yes it's activated with the DUpgrade in vm.go. I thought it was easier to keep Coreth and Subnet-EVM closer in line rather than having a different mechanism.
Additionally, we can't import the Warp precompile in the params/ package, so it needs to be done externally anyways. Open to suggestion, but after playing around a bit, I thought the best path was to simply share the same code with Subnet-EVM and set the PrecompileUpgrades field in vm.go here: https://github.com/ava-labs/coreth/blob/migrate-warp-precompile/plugin/evm/vm.go#L470
There was a problem hiding this comment.
I was just in favor of having less code to reduce risk. But I think that's fine.
params/precompile_upgrade.go
Outdated
There was a problem hiding this comment.
IMO it's probably better to skip unused code, and this should not be needed by coreth since precompiles should be activated by direct network upgrades.
There was a problem hiding this comment.
Co-authored-by: Ceyhun Onur <[email protected]> Signed-off-by: aaronbuchwald <[email protected]>
aaronbuchwald
dismissed stale reviews from darioush and ceyonur
The base branch was changed.
This PR migrates Coreth to use the latest precompile package structure from Subnet-EVM in preparation for migrating the Warp precompile.