tests: only enable metrics and revert to disable if already disabled

ava-labs · Jan 13, 2025 · 2164d72 · 2164d72
1 parent 469767e
commit 2164d72
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 16 deletions.
diff --git a/warp/handlers/signature_request_test.go b/warp/handlers/signature_request_test.go
@@ -22,10 +22,13 @@ import (
 )
 
 func TestMessageSignatureHandler(t *testing.T) {
-	metrics.Enabled = true
-	t.Cleanup(func() {
-		metrics.Enabled = false
-	})
+	metricsEnabled := metrics.Enabled
+	if !metricsEnabled {
+		metrics.Enabled = true
+		t.Cleanup(func() {
+			metrics.Enabled = false
+		})
+	}
 
 	database := memdb.New()
 	snowCtx := utils.TestSnowContext()
@@ -131,10 +134,13 @@ func TestMessageSignatureHandler(t *testing.T) {
 }
 
 func TestBlockSignatureHandler(t *testing.T) {
-	metrics.Enabled = true
-	t.Cleanup(func() {
-		metrics.Enabled = false
-	})
+	metricsEnabled := metrics.Enabled
+	if !metricsEnabled {
+		metrics.Enabled = true
+		t.Cleanup(func() {
+			metrics.Enabled = false
+		})
+	}
 
 	database := memdb.New()
 	snowCtx := utils.TestSnowContext()

diff --git a/warp/verifier_backend_test.go b/warp/verifier_backend_test.go
@@ -25,10 +25,13 @@ import (
 )
 
 func TestAddressedCallSignatures(t *testing.T) {
-	metrics.Enabled = true
-	t.Cleanup(func() {
-		metrics.Enabled = false
-	})
+	metricsEnabled := metrics.Enabled
+	if !metricsEnabled {
+		metrics.Enabled = true
+		t.Cleanup(func() {
+			metrics.Enabled = false
+		})
+	}
 
 	database := memdb.New()
 	snowCtx := utils.TestSnowContext()
@@ -144,10 +147,13 @@ func TestAddressedCallSignatures(t *testing.T) {
 }
 
 func TestBlockSignatures(t *testing.T) {
-	metrics.Enabled = true
-	t.Cleanup(func() {
-		metrics.Enabled = false
-	})
+	metricsEnabled := metrics.Enabled
+	if !metricsEnabled {
+		metrics.Enabled = true
+		t.Cleanup(func() {
+			metrics.Enabled = false
+		})
+	}
 
 	database := memdb.New()
 	snowCtx := utils.TestSnowContext()