chore: address pr comments

ava-labs · Oct 23, 2024 · 60e1744 · 60e1744
1 parent 0532f91
commit 60e1744
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 15 deletions.
diff --git a/src/vms/pvm/etna-builder/builder.test.ts b/src/vms/pvm/etna-builder/builder.test.ts
@@ -1077,19 +1077,15 @@ describe('./src/vms/pvm/etna-builder/builder.test.ts', () => {
     });
   });
 
-  describe.each([
-    {
-      name: 'should throw error if weight on a validator is 0',
-      validator: ConvertSubnetValidator.fromNative(
-        nodeId,
-        BigInt(0 * 1e9),
-        BigInt(0 * 1e9),
-        new ProofOfPossession(blsPublicKeyBytes(), blsSignatureBytes()),
-        PChainOwner.fromNative([testAddress1], 1),
-        PChainOwner.fromNative([testAddress1], 1),
-      ),
-    },
-  ])('$name', ({ validator }) => {
+  it('should throw error if weight on a validator is 0', () => {
+    const validator = ConvertSubnetValidator.fromNative(
+      nodeId,
+      BigInt(0 * 1e9),
+      BigInt(0 * 1e9),
+      new ProofOfPossession(blsPublicKeyBytes(), blsSignatureBytes()),
+      PChainOwner.fromNative([testAddress1], 1),
+      PChainOwner.fromNative([testAddress1], 1),
+    );
     const utxos = testUtxos();
     try {
       newConvertSubnetTx(

diff --git a/src/vms/pvm/etna-builder/builder.ts b/src/vms/pvm/etna-builder/builder.ts
@@ -65,6 +65,7 @@ import {
   INTRINSIC_IMPORT_TX_COMPLEXITIES,
   INTRINSIC_REMOVE_SUBNET_VALIDATOR_TX_COMPLEXITIES,
   INTRINSIC_TRANSFER_SUBNET_OWNERSHIP_TX_COMPLEXITIES,
+  INTRINSIC_CONVERT_SUBNET_TX_COMPLEXITIES,
   getAuthComplexity,
   getInputComplexity,
   getOutputComplexity,
@@ -76,7 +77,6 @@ import {
 import { spend } from './spend';
 import { useSpendableLockedUTXOs, useUnlockedUTXOs } from './spend-reducers';
 import type { ConvertSubnetValidator } from '../../../serializable/fxs/pvm/convertSubnetValidator';
-import { INTRINSIC_CONVERT_SUBNET_TX_COMPLEXITIES } from '../txs/fee/constants';
 
 /**
  * Creates OutputOwners used for change outputs with the specified
@@ -1353,7 +1353,7 @@ export type NewConvertSubnetTxProps = TxProps<{
 
 /**
  * Creates a new unsigned PVM convert subnet transaction
- * (`NewConvertSubnetTx`) using calculated dynamic fees.
+ * (`ConvertSubnetTx`) using calculated dynamic fees.
  *
  * @param props {NewConvertSubnetTxProps}
  * @param context {Context}

diff --git a/src/vms/pvm/txs/fee/index.ts b/src/vms/pvm/txs/fee/index.ts
@@ -9,6 +9,7 @@ export {
   INTRINSIC_IMPORT_TX_COMPLEXITIES,
   INTRINSIC_REMOVE_SUBNET_VALIDATOR_TX_COMPLEXITIES,
   INTRINSIC_TRANSFER_SUBNET_OWNERSHIP_TX_COMPLEXITIES,
+  INTRINSIC_CONVERT_SUBNET_TX_COMPLEXITIES,
 } from './constants';
 
 export {