testing: improve e2e test bootstrapping #3690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tests/fixture/e2e/env.go
Outdated
Comment on lines
165
to
175
| allValidatorsBootstrapped := true | ||
| for i := len(pendingBootstappingChains) - 1; i >= 0; i-- { | ||
| pending := pendingBootstappingChains[i] | ||
| uri, err := network.GetURIForNodeID(pending.validatorID) | ||
| require.NoError(err) | ||
| infoClient := info.NewClient(uri) | ||
| isBootstrapped, err := infoClient.IsBootstrapped(tc.DefaultContext(), pending.chainID.String()) | ||
| // Ignore errors since a chain id that is not yet known will result in a recoverable error. | ||
| if err != nil || !isBootstrapped { | ||
| allValidatorsBootstrapped = false | ||
| continue |
There was a problem hiding this comment.
Why do we perform an IsBootstrapped check here rather than checking if the node is healthy? If the node reports healthy, all bootstrapping checks should pass and this will include correctly checking that dynamic state sync has completed (which is handled as a bit of an outlier).
There was a problem hiding this comment.
by the time we reach this point, the health check was already complete against all the nodes. Some differences:
- The health checking doesn't seem to be chain-specific, whereas the bootstrapping test is.
- When doing the health checking, the port would get dynamically refreshed. That's won't happen during the bootstrapping testing.
tsachiherman
changed the title
maru-ava
approved these changes
Jan 31, 2025
aaronbuchwald
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
This PR remove the redundant testing for bootstrapping nodes after the nodes have already been verified to be healthy.
How this works
trivial.
How this was tested
Tested using existing tests.
Need to be documented in RELEASES.md?
no.