[testing] Update golangci-lint to latest version #3617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marun
commented
Dec 21, 2024
marun
commented
Dec 21, 2024
marun
force-pushed
the
update-lint-version
branch
from
3809bfe to
cb25e24
Compare
marun
commented
Dec 27, 2024
| @@ -128,6 +128,7 @@ linters-settings: | |||
| gosec: | |||
| excludes: | |||
| - G107 # Url provided to HTTP request as taint input https://securego.io/docs/rules/g107 | |||
| - G115 # TODO(marun) Enable this ruleset in a follow-up PR | |||
There was a problem hiding this comment.
Added issue to track enabling G115: #3624
StephenButtolph
approved these changes
Dec 27, 2024
yacovm
reviewed
Dec 27, 2024
yacovm
reviewed
Dec 27, 2024
| @@ -67,8 +67,6 @@ func (c *Client) Apply(requests map[ids.ID]*atomic.Requests, batches ...database | |||
| Batches: make([]*sharedmemorypb.Batch, len(batches)), | |||
| } | |||
| for key, value := range requests { | |||
| key := key | |||
yacovm
approved these changes
Dec 29, 2024
Co-authored-by: Stephen Buttolph <[email protected]> Signed-off-by: marun <[email protected]>
Co-authored-by: Stephen Buttolph <[email protected]> Signed-off-by: marun <[email protected]>
Co-authored-by: Stephen Buttolph <[email protected]> Signed-off-by: marun <[email protected]>
Co-authored-by: Stephen Buttolph <[email protected]> Signed-off-by: marun <[email protected]>
marun
force-pushed
the
update-lint-version
branch
from
94b2e7f to
01568af
Compare
|
Rebased |
tsachiherman
pushed a commit
that referenced
this pull request
Jan 29, 2025
Signed-off-by: marun <[email protected]> Co-authored-by: Stephen Buttolph <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates golangci-lint to latest version.
TODO
How this was tested
CI
Need to be documented in RELEASES.md?
N/A