-
Notifications
You must be signed in to change notification settings - Fork 710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[antithesis] Enable reuse of banff e2e test for antithesis testing #3554
base: master
Are you sure you want to change the base?
Conversation
Switched to draft in light of wanting to rebase on #3557 |
cf8a4d4
to
292016a
Compare
Moving to draft and adding a bunch of TODOs prompted by a manually-triggered antithesis run. The error handling of the e2e test is not sufficiently robust, so there are a lot of unhelpful errors that need to be addressed before this PR will be mergeable. |
2dbfdce
to
6e0b41c
Compare
This PR has become stale because it has been open for 30 days with no activity. Adding the |
Why this should be merged
Having to duplicate existing test coverage to benefit from execution with antithesis is not ideal. Better to be able to trivially refactor compatible e2e coverage for reuse. This PR refactors the banff e2e test for reuse with antithesis to demonstrate that this is possible.
How this works
APITestFunction
type that a compatible e2e test can implement to allow for execution with both ginkgo and antithesisExecuteAPITest
helper to simplify execution of anAPITestFunction
with ginkgoAPITestFunction
executed byExecuteAPITest
How this was tested
CI
TODO
Ensure banff test is actually compatible with the funding provided by the antithesis workload
Ensure antithesis-specific test abort if shared memory is not found (indicating node restart)
Need to be documented in RELEASES.md?
N/A