Introducing GenericNodeID #1989
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abi87
force-pushed
the
genericNodeID
branch
from
078fbed to
536e573
Compare
abi87
force-pushed
the
genericNodeID
branch
from
c973ffc to
3a4a6bd
Compare
abi87
force-pushed
the
genericNodeID
branch
from
6f8426a to
87e850b
Compare
|
This PR has become stale because it has been open for 30 days with no activity. Adding the |
|
This PR has become stale because it has been open for 30 days with no activity. Adding the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
We relax the length requirement of NodeID type and allow avalanche go to smoothly handle NodeID of potentially different sizes and be more future proof.
Coreth counterpart is ava-labs/coreth#339
How this works
Renamed existing nodeID to ids.ShortNodeID and introduced a new ids.NodeID type with no constraints over its size.
How this was tested
CI (mainnet sync tbd)