Fix build errors, add hardcoded ACP explainer #1803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meaghanfitzgerald
requested review from
laviniat1996,
martineckardt,
Andyvargtz,
ashucoder9,
usmaneth and
amandamarquis1
as code owners
Deploying avalanche-docs with
|
| Latest commit: |
58a6e67
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7f3eee83.avalanche-docs.pages.dev |
| Branch Preview URL: | https://meag-fix-build.avalanche-docs.pages.dev |
Comment on lines
-274
to
+282
| "https://raw.githubusercontent.com/ava-labs/teleporter/main/contracts/src/Teleporter/upgrades/", | ||
| "https://raw.githubusercontent.com/ava-labs/teleporter/main/contracts/src/teleporter/registry/", | ||
| documents: ["README.md"], | ||
| outDir: "docs/build/cross-chain/teleporter/", | ||
| // change file name and add metadata correct links | ||
| modifyContent(filename, content) { | ||
| if (filename.includes("README")) { | ||
| const updatedContent = replaceRelativeLinks( | ||
| content, | ||
| "https://github.com/ava-labs/teleporter/blob/main/contracts/src/Teleporter/upgrades/" | ||
| "https://github.com/ava-labs/teleporter/blob/main/contracts/src/teleporter/registry/" |
There was a problem hiding this comment.
these were the broken urls
There was a problem hiding this comment.
|
/gt docs/learn/acp.md i18n/es/docusaurus-plugin-content-docs/current/learn/acp.md spanish |
|
🎉Translation completed! |
|
thank you @meaghanfitzgerald for this contribution |
laviniat1996
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
the build has been broken due to invalid
sourceBaseUrls inremoteContent.js. These Urls point to.mdfiles in remote repositories (ie. https://github.com/ava-labs/avalanchego/) that are pulled into docs viadocusaurus-plugin-remote-contentcommunity plugin.I wrote a detailed guide on how I implemented
docusaurus-plugin-remote-contentto pull remote docs. Many FAQs are answered there.How this works
docs/learn/acp.mdHow these changes were tested
yarn buildyarn start