Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Teleporter devnet guide #1624

Closed
wants to merge 15 commits into from

Conversation

cam-schultz
Copy link

Docs PR Template

Why this should be merged

Adds instructions for deploying Teleporter and running a relayer on a devnet set up through avalanche-cli

How this works

See above

How these changes were tested

N/A

To prevent any errors while building

  • [] run vale /docs/file/path on all changed .md files to ensure all grammar rules pass
  • [] run markdownlint /docs/file/path on all changed .md files to ensure all linting rules pass
  • [] complete the above two checks and all additional rules outlined in style-checker-notes.md to
    ensure all checks pass

If a document was removed/deleted

  • [] the path to that doc must be redirected to a valid URL via the
    _redirects file
  • [] _redirects were manually verified with the cloudflare preview link
  • [] sidebars.json reflects all changes made to file path

If a document was moved

  • [] all files that were moved from their current directory to a new path have had their paths
    redirected via the _redirects file
  • [] _redirects were manually verified with the cloudflare preview link
  • [] sidebars.json reflects all changes made to file path


<!-- vale off -->

[Teleporter](https://github.com/ava-labs/teleporter) is a cross-chain messaging protocol built on top of Warp. Teleporter provides a user-friendly interface to Warp that provides additional features such as replay protection, message delivery incentives, and message execution, to name a few.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a link to something explaining what is warp

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably a first paragraph is needed as introduction of what is comming next in the tutorial, adding a basic explanation of the why of wapr/teleporter

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a link to the Warp documentation in the "Create a Devnet with Warp-Enabled Subnets" section.

As for the changes here, can you suggest specific changes? I believe the link to the Teleporter repo, a brief explanation of what Teleporter is, and how we are using it to extend the devnet example already covers what you asked for.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs/tooling/cli-guides/setup-a-devnet.md Outdated Show resolved Hide resolved
docs/tooling/cli-guides/setup-a-devnet.md Outdated Show resolved Hide resolved

[Teleporter](https://github.com/ava-labs/teleporter) is a cross-chain messaging protocol built on top of Warp. Teleporter provides a user-friendly interface to Warp that provides additional features such as replay protection, message delivery incentives, and message execution, to name a few.

Now that the Warp-enabled devnet is up and running, Teleporter can be deployed to the C-Chain and subnet-evm subnets. Teleporter is deployed using [Nick's method](https://yamenmerhi.medium.com/nicks-method-ethereum-keyless-execution-168a6659479c) to ensure that the Teleporter contract is deployed to the same address on all chains. For instructions on how to deploy Teleporter, please see the guide [here.](https://github.com/ava-labs/teleporter/blob/main/utils/contract-deployment/README.md) Follow those instructions to deploy Teleporter to Subnet A, Subnet B, and the C-Chain.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we need to list here the commands, to deploy the contract(s) and to fund the needed addresses, with a brief explanation of those.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer to not repeat documentation in multiple places - the requested steps are already included in the linked documentation.

docs/tooling/cli-guides/setup-a-devnet.md Outdated Show resolved Hide resolved

#### Interact with Teleporter

With the Warp-enabled devnet deployed, Teleporter deployed on each of the chains, and an AWM Relayer instance running, the Teleporter development environment is ready to go! A good place to start are the [example applications](https://github.com/ava-labs/teleporter/blob/main/contracts/src/CrossChainApplications/README.md) included in the Teleporter repository. These dApps are built on top of Teleporter and demonstrate various cross-chain messaging use cases.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you add a simplest example, maybe using curl, outside of any other ref, and then link to other docs

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think any example included inline here would make this doc unnecessarily messy. Instead, I've linked to the various Teleporter getting started guides and example scripts to serve as a starting point. Specifically, https://github.com/ava-labs/teleporter/blob/main/scripts/local/examples/basic_send_receive.sh includes all the commands for interacting with Teleporter, and serves as documentation in and of itself.

@laviniat1996
Copy link
Contributor

@felipemadero Could you please check the comments and see if those conversations can be solved?

@laviniat1996
Copy link
Contributor

@cam-schultz Just a friendly reminder to check on this when you have time

@cam-schultz
Copy link
Author

@cam-schultz Just a friendly reminder to check on this when you have time

I don't think there are any comments that I haven't responded to yet in this PR. @felipemadero , are you planning on taking another pass at this? Otherwise we should decide whether to merge or close this PR.

@laviniat1996
Copy link
Contributor

@cam-schultz the conflicting files are the issue now, and I cannot fix it myself because it's your fork branch :(

@cam-schultz
Copy link
Author

@cam-schultz the conflicting files are the issue now, and I cannot fix it myself because it's your fork branch :(

Ahh, my bad. Synced my fork and merged in master here. All conflicts should be resolved now 👍

@cam-schultz
Copy link
Author

Closing this as the upcoming Teleporter integration into avalanche-cli will largely invalidate these steps. This closed PR can be used as a reference when putting together documentation for that integration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants