support urls without scheme #2242
Conversation
|
|
||
| func HasScheme(rpcURL string) (bool, error) { | ||
| if parsedURL, err := url.Parse(rpcURL); err != nil { | ||
| if !strings.Contains(err.Error(), "first path segment in URL cannot contain colon") { |
There was a problem hiding this comment.
- not clear for me why we can't return what url.Parse() gives us and need additional check for the type of error.
- I feel like we need unittests for this to explain functionality like example where this
first path segment in URLis relavant - should be moved to utils/net.go
so the main question is why it has to be more complicated then to rely on url.Parse to check if it's a url and has some scheme and then check if Scheme is not empty
| if hasScheme { | ||
| client, err = ethclient.DialContext(ctx, rpcURL) | ||
| } else { | ||
| client, _, err = FindOutScheme(rpcURL) |
There was a problem hiding this comment.
nit: not sure FIndOutScheme is a good name for this as it returns a EthClient. I feel like FindOutScheme should be a helper function to detect endpoint protocol and correct corresponing rpcURL by adding scheme so ethclient.DialContext(ctx, rpcURL) can be still used to get a client
There was a problem hiding this comment.
pls feel free to ignore this comment
| @@ -259,15 +261,80 @@ func SendTransaction( | |||
| return err | |||
| } | |||
|
|
|||
| func FindOutScheme(rpcURL string) (ethclient.Client, string, error) { | |||
There was a problem hiding this comment.
I feel like it will be more flexible if this detects and returns scheme not ethclient.Client
in this case it will have more generic use
Why this should be merged
It is desirable for cmdline ux to be able to provide urls without scheme as for example 127.0.0.1:9650/ext/bc/2TaAjq8oF5PRrGDzX7DvWxsdei1AZvHRZ7TAdNpqrbCEZKcQ55/rpc
This capability is presented in tools like forge.
How this works
How this was tested
How is this documented