Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ansible): rename some variables to conform new lint rules #3988

Merged
merged 2 commits into from
Nov 16, 2023

Conversation

xmfcx
Copy link
Contributor

@xmfcx xmfcx commented Nov 15, 2023

Description

Related PR:

Updating to ansible-lint version

  • from rev: v6.16.1
  • to rev: v6.22.0

caused following errors:

var-naming[no-role-prefix]: Variables names from within roles should use role_name_ as a prefix. Underlines are accepted before the prefix.

More info can be found in: https://ansible.readthedocs.io/projects/lint/rules/var-naming/

This PR renames the variables and their usages in this repository to fix this.

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@xmfcx xmfcx self-assigned this Nov 15, 2023
@xmfcx
Copy link
Contributor Author

xmfcx commented Nov 15, 2023

I will temporarily also bump up the version just to see if the new lint rules work.

@xmfcx
Copy link
Contributor Author

xmfcx commented Nov 15, 2023

With the updated version, it passes the linter: https://github.com/autowarefoundation/autoware/actions/runs/6874788397/job/18697109204?pr=3988#step:4:87

I will now revert the version bump, it will be merged in its own PR anyways.

@xmfcx xmfcx force-pushed the refactor/ansible-vars branch from bfde3ea to 6f65503 Compare November 15, 2023 08:36
@xmfcx xmfcx requested a review from mitsudome-r November 15, 2023 08:59
@xmfcx xmfcx added type:installation Issues or improvements related to the installation process of the software. type:ci Continuous Integration (CI) processes and testing. labels Nov 15, 2023
@xmfcx xmfcx merged commit 439c8cd into main Nov 16, 2023
14 checks passed
@xmfcx xmfcx deleted the refactor/ansible-vars branch November 16, 2023 11:54
@xmfcx
Copy link
Contributor Author

xmfcx commented Nov 16, 2023

@xmfcx xmfcx mentioned this pull request Dec 6, 2023
4 tasks
oguzkaganozt pushed a commit that referenced this pull request Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:ci Continuous Integration (CI) processes and testing. type:installation Issues or improvements related to the installation process of the software.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants