-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: port autoware_kalman_filter from autoware.universe #141
base: main
Are you sure you want to change the base?
feat: port autoware_kalman_filter from autoware.universe #141
Conversation
Signed-off-by: liu cui <[email protected]>
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Signed-off-by: liu cui <[email protected]>
Signed-off-by: liu cui <[email protected]>
Signed-off-by: liu cui <[email protected]>
there is a required item of ci failed (cpp-check-differicial),below is the report Do you know how to solve this problem? @liuXinGangChina @mitsudome-r |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #141 +/- ##
==========================================
- Coverage 78.75% 73.62% -5.14%
==========================================
Files 11 16 +5
Lines 193 417 +224
Branches 73 201 +128
==========================================
+ Hits 152 307 +155
- Misses 11 40 +29
- Partials 30 70 +40
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since it’s a porting task, I’m keeping the review to a minimum.
common/autoware_kalman_filter/include/autoware/kalman_filter/kalman_filter.hpp
Show resolved
Hide resolved
Sorry, I accidentally closed the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@cyn-liu Could you also create a PR to remove the package in Autoware Universe so that we can merge simultaneously? |
Description
Port autoware_kalman_filter from Autoware.Universe.
Related links
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.