Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: port autoware_kalman_filter from autoware.universe #141

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

cyn-liu
Copy link
Contributor

@cyn-liu cyn-liu commented Dec 27, 2024

Description

Port autoware_kalman_filter from Autoware.Universe.

Related links

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Copy link

github-actions bot commented Dec 27, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@cyn-liu
Copy link
Contributor Author

cyn-liu commented Jan 7, 2025

there is a required item of ci failed (cpp-check-differicial),below is the report
image

Do you know how to solve this problem? @liuXinGangChina @mitsudome-r

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 69.19643% with 69 lines in your changes missing coverage. Please review.

Project coverage is 73.62%. Comparing base (4cb18f5) to head (bf4aab9).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
...lman_filter/test/test_time_delay_kalman_filter.cpp 65.82% 3 Missing and 24 partials ⚠️
...ommon/autoware_kalman_filter/src/kalman_filter.cpp 58.06% 23 Missing and 3 partials ⚠️
...autoware_kalman_filter/test/test_kalman_filter.cpp 74.46% 1 Missing and 11 partials ⚠️
...are_kalman_filter/src/time_delay_kalman_filter.cpp 88.57% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #141      +/-   ##
==========================================
- Coverage   78.75%   73.62%   -5.14%     
==========================================
  Files          11       16       +5     
  Lines         193      417     +224     
  Branches       73      201     +128     
==========================================
+ Hits          152      307     +155     
- Misses         11       40      +29     
- Partials       30       70      +40     
Flag Coverage Δ *Carryforward flag
differential 69.19% <69.19%> (?)
total 78.75% <ø> (ø) Carriedforward from 97e5cf2

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@youtalk youtalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it’s a porting task, I’m keeping the review to a minimum.

@youtalk youtalk enabled auto-merge (squash) January 8, 2025 08:45
auto-merge was automatically disabled January 8, 2025 10:14

Pull request was closed

@mitsudome-r mitsudome-r reopened this Jan 8, 2025
@mitsudome-r
Copy link
Member

Sorry, I accidentally closed the PR.

Copy link
Member

@youtalk youtalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mitsudome-r
Copy link
Member

@cyn-liu Could you also create a PR to remove the package in Autoware Universe so that we can merge simultaneously?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants