Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(.github): add .github CODEOWNERS #133

Merged
merged 1 commit into from
Dec 19, 2024
Merged

chore(.github): add .github CODEOWNERS #133

merged 1 commit into from
Dec 19, 2024

Conversation

youtalk
Copy link
Member

@youtalk youtalk commented Dec 19, 2024

Description

This PR adds @autowarefoundation/autoware-core-global-codeowners to .github CODEOWNERS.

Related links

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Copy link

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@youtalk youtalk requested review from xmfcx and mitsudome-r December 19, 2024 01:43
@youtalk youtalk self-assigned this Dec 19, 2024
@youtalk youtalk marked this pull request as ready for review December 19, 2024 01:43
@xmfcx
Copy link
Contributor

xmfcx commented Dec 19, 2024

This will be appended to the end of the file and override the rules above. Standard package owners won't be added as reciewers anymore. We need a version of this that is qppended to the start of the file.

@xmfcx
Copy link
Contributor

xmfcx commented Dec 19, 2024

  • .github/CODEOWNERS-manual-pre
  • .github/CODEOWNERS-manual-post

separation

@xmfcx
Copy link
Contributor

xmfcx commented Dec 19, 2024

Oh sorry this is for .github folder. This is narrow enough, Iwill approve. I thought it was just *

@youtalk
Copy link
Member Author

youtalk commented Dec 19, 2024

Yes. That's the difference from #104.

@youtalk youtalk merged commit 4cb18f5 into main Dec 19, 2024
27 checks passed
@youtalk youtalk deleted the youtalk-patch-1 branch December 19, 2024 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants