Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(build-and-test*): use autoware:core-devel image and reconfigure workflows #129

Closed
wants to merge 4 commits into from

Conversation

youtalk
Copy link
Member

@youtalk youtalk commented Dec 17, 2024

Description

This PR changes the container images used for the build-and-test-differential jobs from autoware:universe-devel to autoware:core-devel. It reduces the time for the docker pull.

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: Yutaka Kondo <[email protected]>
Copy link

github-actions bot commented Dec 17, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@youtalk youtalk marked this pull request as ready for review December 17, 2024 12:53
@youtalk youtalk requested a review from a team December 17, 2024 12:53
Signed-off-by: M. Fatih Cırıt <[email protected]>
@@ -76,7 +76,7 @@ jobs:
clang-tidy-differential:
needs: build-and-test-differential
runs-on: ubuntu-22.04
container: ghcr.io/autowarefoundation/autoware:universe-devel-cuda
container: ghcr.io/autowarefoundation/autoware:core-devel
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
container: ghcr.io/autowarefoundation/autoware:core-devel
container: ghcr.io/autowarefoundation/autoware:core-devel-cuda

I think we can keep running this on cuda since it will be more inclusive.

In the future we can refactor to simplify this entire workflow.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the autoware.core does not depend on the CUDA library, the autoware:core-devel-cuda image no longer exists. Therefore, staying with autoware:core-devel is fine.
autowarefoundation/autoware#5363
https://github.com/autowarefoundation/autoware/pkgs/container/autoware/versions

@xmfcx
Copy link
Contributor

xmfcx commented Dec 17, 2024

ed56568 here I added the remaining build-and-test* workflows. Now I will run the test against the daily verison.

@xmfcx xmfcx changed the title feat(.github): use autoware:core-devel image for build-and-test-differential jobs feat(.github): use autoware:core-devel image for build-and-test* jobs Dec 17, 2024
@xmfcx xmfcx changed the title feat(.github): use autoware:core-devel image for build-and-test* jobs ci(.github): use autoware:core-devel image for build-and-test* jobs Dec 17, 2024
@xmfcx
Copy link
Contributor

xmfcx commented Dec 17, 2024

With these smaller images, we can utilize the public runners, updating those now.

Signed-off-by: M. Fatih Cırıt <[email protected]>
@xmfcx
Copy link
Contributor

xmfcx commented Dec 17, 2024

Changes summary:

Testing on:

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.25%. Comparing base (051d227) to head (776fc66).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #129   +/-   ##
=======================================
  Coverage   73.25%   73.25%           
=======================================
  Files          10       10           
  Lines         172      172           
  Branches       68       68           
=======================================
  Hits          126      126           
  Misses         19       19           
  Partials       27       27           
Flag Coverage Δ
total 73.25% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@xmfcx xmfcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@youtalk san, please review my additional changes too. I think once we switch the clang-tidy to cuda version, this can be merged ✅

I would probably change the PR title to:

  • ci(build-and-test*): use autoware:core-devel image and reconfigure workflows

@youtalk youtalk requested review from xmfcx and mitsudome-r December 18, 2024 02:01
@youtalk youtalk changed the title ci(.github): use autoware:core-devel image for build-and-test* jobs ci(build-and-test*): use autoware:core-devel image and reconfigure workflows Dec 18, 2024
@xmfcx
Copy link
Contributor

xmfcx commented Dec 18, 2024

@youtalk youtalk closed this Dec 18, 2024
@youtalk youtalk deleted the use-core-devel-image branch December 18, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants