-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(build-and-test*): use autoware:core-devel
image and reconfigure workflows
#129
Conversation
Signed-off-by: Yutaka Kondo <[email protected]>
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Signed-off-by: M. Fatih Cırıt <[email protected]>
@@ -76,7 +76,7 @@ jobs: | |||
clang-tidy-differential: | |||
needs: build-and-test-differential | |||
runs-on: ubuntu-22.04 | |||
container: ghcr.io/autowarefoundation/autoware:universe-devel-cuda | |||
container: ghcr.io/autowarefoundation/autoware:core-devel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
container: ghcr.io/autowarefoundation/autoware:core-devel | |
container: ghcr.io/autowarefoundation/autoware:core-devel-cuda |
I think we can keep running this on cuda since it will be more inclusive.
In the future we can refactor to simplify this entire workflow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the autoware.core
does not depend on the CUDA library, the autoware:core-devel-cuda
image no longer exists. Therefore, staying with autoware:core-devel
is fine.
autowarefoundation/autoware#5363
https://github.com/autowarefoundation/autoware/pkgs/container/autoware/versions
ed56568 here I added the remaining build-and-test* workflows. Now I will run the test against the daily verison. |
autoware:core-devel
image for build-and-test-differential
jobsautoware:core-devel
image for build-and-test*
jobs
autoware:core-devel
image for build-and-test*
jobsautoware:core-devel
image for build-and-test*
jobs
With these smaller images, we can utilize the public runners, updating those now. |
Signed-off-by: M. Fatih Cırıt <[email protected]>
Signed-off-by: M. Fatih Cırıt <[email protected]>
Changes summary:
Testing on:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #129 +/- ##
=======================================
Coverage 73.25% 73.25%
=======================================
Files 10 10
Lines 172 172
Branches 68 68
=======================================
Hits 126 126
Misses 19 19
Partials 27 27
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@youtalk san, please review my additional changes too. I think once we switch the clang-tidy to cuda version, this can be merged ✅
I would probably change the PR title to:
- ci(build-and-test*): use autoware:core-devel image and reconfigure workflows
autoware:core-devel
image for build-and-test*
jobsautoware:core-devel
image and reconfigure workflows
|
Description
This PR changes the container images used for the
build-and-test-differential
jobs fromautoware:universe-devel
toautoware:core-devel
. It reduces the time for thedocker pull
.Related links
Parent Issue:
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.