-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tart #103
Tart #103
Conversation
Fixes MunkiImporter to grab the package and not the downloaded archive to prevent this error: The following recipes failed: com.github.apizz.munki.Tart Error in com.github.apizz.munki.Tart: Processor: MunkiImporter: Error: creating pkginfo for ~/Library/AutoPkg/Cache/com.github.apizz.munki.Tart/downloads/tart-arm64.tar.gz failed: ~/Library/AutoPkg/Cache/com.github.apizz.munki.Tart/downloads/tart-arm64.tar.gz is not a valid installer item!
This commit adds architecture support to match the parent recipe: autopkg/wegotoeleven-recipes#4
Hey @kevinmcox . Give me a verbose output run and I'll get you a :rubber_stamp: 😃 |
<key>Processor</key> | ||
<string>com.github.homebysix.FindAndReplace/FindAndReplace</string> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmmm so at face value I don't agree with this change. This adds a seemingly unnecessary dependency. Can you explain why this custom processor is necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is because the Intel download is available as amd64
but for Munki's supported architectures you need to specify x86_64
.
This Find and Replace processor allows you to configure only a single ARCH
variable and have it cover both use cases.
The alternative is to have both DOWNLOAD_ARCH
and SUPPORTED_ARCH
variables that need to be configured as distinct values.
okee dokee
|
This PR has two commits: