Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Oracle Plugin Forex #41

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Oracle Plugin Forex #41

wants to merge 4 commits into from

Conversation

NodeSphereGL
Copy link

@NodeSphereGL NodeSphereGL commented Dec 18, 2024 •
edited
Loading

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Does your submission pass tests?
  • Have you lint your code locally prior to submission?

Jason-Zhangxin-Chen
Jason-Zhangxin-Chen reviewed Feb 6, 2025
View reviewed changes
plugins/forex_nodesphere/forex_nodesphere.go
return price, fmt.Errorf("wrong base %s", to)
}

price.Symbol = s
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add below statement after line 138 as we introduced some update in the master.

	price.Volume = types.DefaultVolume.String()

Jason-Zhangxin-Chen
Jason-Zhangxin-Chen reviewed Feb 6, 2025
View reviewed changes
plugins/forex_nodesphere/forex_nodesphere.go Outdated

func main() {
conf := common.ResolveConf(os.Args[0], &defaultConfig)
adapter := common.NewPlugin(conf, NewNPClient(conf), version)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we made few update on master, now you need to rebase it by adding specifying the plugin type when you create a new plugin:

adapter := common.NewPlugin(conf, NewNPClient(conf), version, types.SrcCEX, nil)

Jason-Zhangxin-Chen
Jason-Zhangxin-Chen requested changes Feb 6, 2025
View reviewed changes
Copy link
Collaborator

@Jason-Zhangxin-Chen Jason-Zhangxin-Chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for your contributions, please also update the README and the sample configuration file, it will help the end user to use the new plugin.
BTW, you need update the make file to get your plugin built.

@NodeSphereGL
Copy link
Author

Thank you for reviewing my code.
I updated code fix and also added README file,
Please help me check,

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jason-Zhangxin-Chen Jason-Zhangxin-Chen Jason-Zhangxin-Chen requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NodeSphereGL @Jason-Zhangxin-Chen