Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.5.10 core library update #155

Merged
merged 3 commits into from
May 1, 2024
Merged

0.5.10 core library update #155

merged 3 commits into from
May 1, 2024

Conversation

heckj
Copy link
Collaborator

@heckj heckj commented Apr 30, 2024

  • update to core library version 0.5.10
  • PatchAction::Insert no longer accepts marks with the 0.5.10 API
    • remove from UDL
    • remove from Rust code making library overlay
    • remove from Swift API

@heckj heckj requested a review from alexjg April 30, 2024 23:10
@heckj heckj self-assigned this Apr 30, 2024
@heckj heckj changed the title 5 10 core 0.5.10 core library update Apr 30, 2024
@heckj
Copy link
Collaborator Author

heckj commented Apr 30, 2024

@alexjg when you have some time, would you look over these changes - I think the only notable API change was removing the marks parameter from PatchAction::Insert, but I may have not spotted other API updates that are important here.

@heckj
Copy link
Collaborator Author

heckj commented May 1, 2024

I found the relevant commits in the recent history - I think this covers the required changes for now, and opened #156 (in addition to #148 ) to expose more API through to the Swift language down the road.

@heckj heckj merged commit 7880d65 into main May 1, 2024
4 checks passed
@heckj heckj deleted the 5_10_core branch May 1, 2024 22:12
@alexjg
Copy link
Collaborator

alexjg commented May 2, 2024

Apologies, I missed this mention. Yes the only change is to the Insert patch.

@heckj
Copy link
Collaborator Author

heckj commented May 2, 2024

No worries, thanks for the double-check!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants