Merge pull request #2 from autolist/f-release-prep

feat: Prep for initial release

.rubocop.yml

@@ -0,0 +1,2 @@
+inherit_gem:
+  autocop: .autocop-rubocop.yml

.travis.yml

@@ -1,5 +1,7 @@
 sudo: false
 language: ruby
 rvm:
+  - 2.4.2
   - 2.5.0
+  - 2.5.1
 before_install: gem install bundler -v 1.16.1

Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    sekreto (0.1.0.2)
+    sekreto (0.1.1)
       aws-sdk-secretsmanager
       multi_json
       rails (>= 4.1, < 5.3)
@@ -51,12 +51,16 @@ GEM
       minitest (~> 5.1)
       tzinfo (~> 1.1)
     arel (9.0.0)
-    aws-partitions (1.81.0)
-    aws-sdk-core (3.20.0)
+    ast (2.4.0)
+    autocop (0.1.4)
+      rubocop (>= 0.52.1)
+      rubocop-rspec (>= 1.22.1)
+    aws-partitions (1.82.0)
+    aws-sdk-core (3.20.2)
       aws-partitions (~> 1.0)
       aws-sigv4 (~> 1.0)
       jmespath (~> 1.0)
-    aws-sdk-secretsmanager (1.1.0)
+    aws-sdk-secretsmanager (1.3.0)
       aws-sdk-core (~> 3)
       aws-sigv4 (~> 1.0)
     aws-sigv4 (1.0.2)
@@ -87,6 +91,10 @@ GEM
     nio4r (2.3.0)
     nokogiri (1.8.2)
       mini_portile2 (~> 2.3.0)
+    parallel (1.12.1)
+    parser (2.5.1.0)
+      ast (~> 2.4.0)
+    powerpack (0.1.1)
     pry (0.11.3)
       coderay (~> 1.1.0)
       method_source (~> 0.9.0)
@@ -117,6 +125,7 @@ GEM
       method_source
       rake (>= 0.8.7)
       thor (>= 0.18.1, < 2.0)
+    rainbow (3.0.0)
     rake (10.5.0)
     rspec (3.7.0)
       rspec-core (~> 3.7.0)
@@ -131,6 +140,16 @@ GEM
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.7.0)
     rspec-support (3.7.1)
+    rubocop (0.55.0)
+      parallel (~> 1.10)
+      parser (>= 2.5)
+      powerpack (~> 0.1)
+      rainbow (>= 2.2.2, < 4.0)
+      ruby-progressbar (~> 1.7)
+      unicode-display_width (~> 1.0, >= 1.0.1)
+    rubocop-rspec (1.25.1)
+      rubocop (>= 0.53.0)
+    ruby-progressbar (1.9.0)
     sprockets (3.7.1)
       concurrent-ruby (~> 1.0)
       rack (> 1, < 3)
@@ -144,6 +163,7 @@ GEM
     thread_safe (0.3.6)
     tzinfo (1.2.5)
       thread_safe (~> 0.1)
+    unicode-display_width (1.3.2)
     websocket-driver (0.7.0)
       websocket-extensions (>= 0.1.0)
     websocket-extensions (0.1.3)
@@ -152,8 +172,9 @@ PLATFORMS
   ruby
 
 DEPENDENCIES
+  autocop (~> 0.1.4)
   bundler (~> 1.16)
-  pry
+  pry (~> 0.11.3)
   rake (~> 10.0)
   rspec (~> 3.0)
   rspec-mocks (~> 3.0)

README.md

@@ -1,5 +1,8 @@
 # Sekreto
 
+[![Gem Version](https://badge.fury.io/rb/sekreto.svg)](https://badge.fury.io/rb/sekreto)
+[![Build Status](https://travis-ci.org/autolist/sekreto.svg?branch=master)](https://travis-ci.org/autolist/sekreto)
+
 Use AWS Secrets Manager from Ruby, with rails support
 
 ## Installation

Rakefile

@@ -1,6 +1,21 @@
+require 'rubygems'
+require 'bundler'
 require 'bundler/gem_tasks'
 require 'rspec/core/rake_task'
+require 'rubocop/rake_task'
 
-RSpec::Core::RakeTask.new(:spec)
+Bundler::GemHelper.install_tasks
 
-task default: :spec
+task test: %i[rubocop spec]
+task default: :test
+
+# Rubocop
+desc 'Run Rubocop lint checks'
+task :rubocop do
+  RuboCop::RakeTask.new
+end
+
+desc 'Run specs'
+RSpec::Core::RakeTask.new('spec') do |task|
+  task.pattern = 'spec/**/*_spec.rb'
+end

lib/sekreto/version.rb

@@ -1,3 +1,3 @@
 module Sekreto
-  VERSION = '0.1.0.2'.freeze
+  VERSION = '0.1.1'.freeze
 end

sekreto.gemspec

@@ -22,10 +22,11 @@ Gem::Specification.new do |spec|
   spec.add_dependency 'multi_json'
   spec.add_dependency 'rails', ['>= 4.1', '< 5.3']
 
+  spec.add_development_dependency 'autocop', '~> 0.1.4'
   spec.add_development_dependency 'bundler', '~> 1.16'
+  spec.add_development_dependency 'pry', '~> 0.11.3'
   spec.add_development_dependency 'rake', '~> 10.0'
   spec.add_development_dependency 'rspec', '~> 3.0'
   spec.add_development_dependency 'rspec-mocks', '~> 3.0'
   spec.add_development_dependency 'stub_env', '~> 1.0'
-  spec.add_development_dependency 'pry'
 end

spec/sekreto/config_spec.rb

@@ -14,7 +14,7 @@
       expect(config.secrets_manager).to be_nil
     end
 
-    context 'fallback lookup' do
+    context 'when fallback lookup' do
       let(:secret_id) { 'MY_SECRET' }
       let(:secret_val) { 'MY_SECRET_VAL' }
 

spec/sekreto_spec.rb

@@ -1,5 +1,6 @@
 RSpec.describe Sekreto do
   subject(:sekreto) { described_class }
+
   let(:manager) { double }
   let(:secret_id) { 'MY_SECRET' }
   let(:secret_response) { OpenStruct.new(secret_string: secret_string) }
@@ -39,18 +40,21 @@
       let(:fallback) { double }
 
       it 'calls fallback lookup' do
-        allow(config).to receive(:fallback_lookup).and_return(fallback)
-        expect(fallback).to receive(:call).once.with(secret_id)
+        allow(config).to receive(:fallback_lookup) { fallback }
+        allow(fallback).to receive(:call).once.with(secret_id)
         sekreto.get_value(secret_id)
       end
     end
 
     context 'when allowed env' do
       let(:allowed_env) { true }
 
+      before do
+        allow(described_class).to receive(:secrets_manager) { manager }
+        allow(manager).to receive(:get_secret_value) { secret_response }
+      end
+
       it 'gets secret value from manager' do
-        allow(described_class).to receive(:secrets_manager).and_return(manager)
-        expect(manager).to receive(:get_secret_value).and_return(secret_response)
         expect(sekreto.get_value(secret_id)).to eq(secret_string)
       end
     end
@@ -68,7 +72,8 @@
 
     context 'when valid json secret' do
       before do
-        expect(sekreto).to receive(:get_value).with(secret_id).and_return(secret_response.secret_string)
+        allow(described_class).to receive(:secrets_manager) { manager }
+        allow(manager).to receive(:get_secret_value) { secret_response }
       end
 
       it 'returns parsed secret' do