Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add model_reference_arn in signature #131

Merged
merged 4 commits into from
Jul 21, 2024

Conversation

suzhoum
Copy link
Contributor

@suzhoum suzhoum commented Jul 11, 2024

Issue #, if available:
Addressed two issues:

  1. Not compatible with latest sagemaker #130
  2. Only create policy when not already existed due to restrictions on "Permission Mutation Policies" and we will lose policy that allows us to create new roles.

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@suzhoum suzhoum force-pushed the add_model_reference_arn branch from 347d2f8 to 50f34b2 Compare July 11, 2024 16:41
Copy link
Contributor

@tonyhoo tonyhoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

@suzhoum suzhoum force-pushed the add_model_reference_arn branch from 42bc2b5 to 2fb8489 Compare July 12, 2024 21:02
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this change also propagate to the AutoGluonSagemakerInferenceModel class followed by wherever deploy is called in cloud_predictor.py and sagemaker_backend.py ?

Copy link
Contributor Author

@suzhoum suzhoum Jul 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might not be necessary. My take is that we need to align all args under the function prepare_container_def with the sagemaker definition here https://sagemaker.readthedocs.io/en/stable/api/inference/model.html#sagemaker.model.Model.prepare_container_def, but we are not really using any of them inside the function.

Copy link

Job PR-131-2fb8489 is done.
Docs are uploaded to https://d12sc05jpx1wj5.cloudfront.net/PR-131/2fb8489/index.html

Copy link

Job PR-131-43c2a6c is done.
Docs are uploaded to https://d12sc05jpx1wj5.cloudfront.net/PR-131/43c2a6c/index.html

@suzhoum suzhoum merged commit dd584f9 into autogluon:master Jul 21, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants