-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add model_reference_arn in signature #131
Conversation
347d2f8
to
50f34b2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick fix!
42bc2b5
to
2fb8489
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this change also propagate to the AutoGluonSagemakerInferenceModel
class followed by wherever deploy is called in cloud_predictor.py
and sagemaker_backend.py
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might not be necessary. My take is that we need to align all args under the function prepare_container_def
with the sagemaker definition here https://sagemaker.readthedocs.io/en/stable/api/inference/model.html#sagemaker.model.Model.prepare_container_def, but we are not really using any of them inside the function.
Job PR-131-2fb8489 is done. |
Job PR-131-43c2a6c is done. |
Issue #, if available:
Addressed two issues:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.