-
-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ISSUE-659 # add ability to refer CSV source value by header #667
Conversation
Hi @luke-zhou 👋 , There is a minor failure here in CI , can you take care please ?
|
Thanks for pointing that out, I have updated the code, that test should pass. |
@luke-zhou hey you can refer the BUILDING.md file for steps to run the tests locally. Let me know in case of any other issues you face. Thanks for the PR! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hi @luke-zhou 👋 , we'll be adding you as a collaborator soon. Then you can merge this PR yourself, and futures PRs once they are approved. |
Done, you can now join via this link! |
Adding a test run console log here for the evidence: Scenario file:
Runner:
Scenario:
Result:
Looks good and works as expected 👍 |
Fixes Issue
PR Branch
Motivation and Context
This PR is aiming to solve the ISSUE-659
Checklist:
New Unit tests were added
Integration tests were added
Test names are meaningful
Feature manually tested and outcome is successful
PR doesn't break any of the earlier features for end users
Branch build passed in CI
No 'package.*' in the imports
Relevant DOcumentation page added or updated with clear instructions and examples for the end user
Http test added to
http-testing
module(if applicable) ?Kafka test added to
kafka-testing
module(if applicable) ?