-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated automated release to support manual trigger #1212
Conversation
@@ -16,7 +17,7 @@ env: | |||
|
|||
jobs: | |||
release: | |||
if: github.event.pull_request.merged && startsWith(github.event.pull_request.head.ref, 'release/') | |||
if: github.event_name == 'workflow_dispatch' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Temporarily removing the automated trigger on PR close, will bring back one manual trigger has been verified. But if we keep this trigger, if everything works as expected we can not even get to testing the manual trigger.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to add back the PR merge trigger now to verify that it works once the release PR is merged?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I was thinking to do a manual release. Then bring it back. Else we have no way to test the manual trigger.
We can then use the automated to cut a release for Auth0-React to include the latest SPA-JS.
4d6ecf3
to
fc2f806
Compare
Updating the release process to avoid depending on the context of the current PR, but instead rely on the branch based on the version found in the
.version
file, restoring behavior like we had when we published through Circle CI..version
file and configure Ship CLI to automatically bump the versionget-version
to read from the.version
file instead of the branch name.softprops/action-gh-release
to create the tag when we create the GitHub release.Note: Because the release-notes are multiline, I was unable to use GITHUB_OUTPUT, but had to resort to GITHUB_ENV instead, exposing the release notes as an environment variable.