Ensure cookieDomain is used when using legacy Cookiestorage (#1071)

auth0 · Feb 4, 2023 · cf01c72 · cf01c72
1 parent 539c8e4
commit cf01c72
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 4 deletions.
diff --git a/__tests__/Auth0Client/loginWithPopup.test.ts b/__tests__/Auth0Client/loginWithPopup.test.ts
@@ -682,7 +682,8 @@ describe('Auth0Client', () => {
         `_legacy_auth0.${TEST_CLIENT_ID}.organization_hint`,
         JSON.stringify(TEST_ORG_ID),
         {
-          expires: 1
+          expires: 1,
+          domain: TEST_DOMAIN
         }
       );
 
@@ -702,11 +703,13 @@ describe('Auth0Client', () => {
       await loginWithPopup(auth0);
 
       expect(<jest.Mock>esCookie.remove).toHaveBeenCalledWith(
-        `_legacy_auth0.${TEST_CLIENT_ID}.organization_hint`, {}
+        `_legacy_auth0.${TEST_CLIENT_ID}.organization_hint`,
+        {}
       );
 
       expect(<jest.Mock>esCookie.remove).toHaveBeenCalledWith(
-        `auth0.${TEST_CLIENT_ID}.organization_hint`, {}
+        `auth0.${TEST_CLIENT_ID}.organization_hint`,
+        {}
       );
     });
 

diff --git a/__tests__/storage.test.ts b/__tests__/storage.test.ts
@@ -132,7 +132,8 @@ describe('CookieStorageWithLegacySameSite', () => {
       `_legacy_${key}`,
       JSON.stringify(value),
       {
-        expires: options.daysUntilExpire
+        expires: options.daysUntilExpire,
+        domain: options.cookieDomain
       }
     );
   });

diff --git a/src/storage.ts b/src/storage.ts
@@ -91,6 +91,10 @@ export const CookieStorageWithLegacySameSite = {
       cookieAttributes.expires = options.daysUntilExpire;
     }
 
+    if (options?.cookieDomain) {
+      cookieAttributes.domain = options.cookieDomain;
+    }
+
     Cookies.set(
       `${LEGACY_PREFIX}${key}`,
       JSON.stringify(value),