Status #84

austenstone · 2024-12-06T16:51:52Z

No description provided.

…and improve development scripts

…int, and improve data handling

github-actions · 2024-12-06T16:52:02Z

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

Package	Version	Score	Details

Scanned Files

backend/src/services/copilot.seats.service.ts

@@ -1,6 +1,6 @@
 import { Endpoints } from '@octokit/types';
 import { Seat } from "../models/copilot.seats.model.js";
-import { QueryTypes, Sequelize } from 'sequelize';
+import { Op, QueryTypes, Sequelize } from 'sequelize';


To fix the problem, we need to remove the unused QueryTypes import from the file. This will resolve the ESLint error and clean up the code. The change should be made in the backend/src/services/copilot.seats.service.ts file, specifically on line 3.

frontend/src/app/main/copilot/copilot-dashboard/dashboard.component.ts

 import { MetricsService } from '../../../services/api/metrics.service';
 import { CopilotMetrics } from '../../../services/api/metrics.service.interfaces';
 import { ActivityResponse, Seat, SeatService } from '../../../services/api/seat.service';
 import { MembersService } from '../../../services/api/members.service';
 import { CopilotSurveyService, Survey } from '../../../services/api/copilot-survey.service';
-import { forkJoin, takeUntil } from 'rxjs';
+import { forkJoin, Subject, Subscription, takeUntil } from 'rxjs';


To fix the problem, we need to remove the unused forkJoin import from the file. This will resolve the ESLint error and clean up the code. The change should be made in the frontend/src/app/main/copilot/copilot-dashboard/dashboard.component.ts file, specifically on line 9 where forkJoin is imported.

frontend/src/app/main/copilot/copilot-dashboard/dashboard.component.ts


  activityTotals?: Record<string, number>;
+  status?: any;


To fix the problem, we need to replace the any type with a more specific type that accurately represents the data that the status variable is expected to hold. This will improve type safety and make the code easier to understand and maintain.

In this case, we can infer from the context that status might be an object with specific properties. We should define an appropriate interface or type alias for this object and use it instead of any.

frontend/src/app/main/copilot/copilot-dashboard/dashboard.component.ts

+          this.status = status;
+          this.statuses[0] = {
+            title: 'GitHub App',
+            message: status.installations.reduce((acc: number, i: any) => acc += i.repos.length, 0) + ' repositories',


To fix the problem, we need to replace the any type with a more specific type that accurately represents the structure of the i variable. This involves defining an interface that describes the expected properties of i and then using this interface in place of any. Specifically, we need to define an interface for the installation object that includes a repos property, which is an array. We will then use this interface in the reduce function to ensure type safety.

frontend/src/app/main/copilot/copilot-metrics/copilot-metrics.component.ts

 import { DateRangeSelectComponent } from "../../../shared/date-range-select/date-range-select.component";
 import { MetricsService } from '../../../services/api/metrics.service';
 import { CopilotMetrics } from '../../../services/api/metrics.service.interfaces';
 import { CopilotMetricsPieChartComponent } from './copilot-metrics-pie-chart/copilot-metrics-pie-chart.component';
 import { MatCardModule } from '@angular/material/card';
 import { Installation, InstallationsService } from '../../../services/api/installations.service';
-import { takeUntil } from 'rxjs';
+import { forkJoin, Subject, Subscription, takeUntil } from 'rxjs';


To fix the problem, we need to remove the unused forkJoin import from the file. This will resolve the ESLint error and clean up the code. The change is straightforward and involves deleting the forkJoin import from the import statement on line 8.

frontend/src/app/main/copilot/copilot-metrics/copilot-metrics.component.ts

    });
  }

-  dateRangeChange(event: {start: Date, end: Date}) {
+  ngOnDestroy() {


frontend/src/app/main/copilot/copilot-value/value.component.ts

    });
  }

+  ngOnDestroy() {


frontend/src/app/services/api/installations.service.ts

@@ -1,4 +1,4 @@
-import { Injectable, OnDestroy } from '@angular/core';
+import { Injectable, OnDestroy, OnInit } from '@angular/core';


To fix the problem, we need to remove the unused OnInit import from the file. This will resolve the ESLint error and clean up the code by removing unnecessary imports.

Locate the import statement on line 1 in the file frontend/src/app/services/api/installations.service.ts.

Remove the OnInit import from the import statement.

frontend/src/app/services/api/installations.service.ts

@@ -72,5 +73,8 @@
    localStorage.setItem('installation', id.toString());
  }

+  getStatus2() {
+    return this.http.get<any>(`${serverUrl}/api/status`);


To fix the problem, we need to replace the any type with a more specific type that accurately represents the data returned by the API endpoint. This involves defining a new interface or type that matches the structure of the response from the ${serverUrl}/api/status endpoint. We will then use this new type in the getStatus2 method.

Define a new interface StatusResponse2 that matches the structure of the response from the ${serverUrl}/api/status endpoint.

Update the getStatus2 method to use the new StatusResponse2 type instead of any.

…nd services for cleaner code

backend/src/services/status.service.ts

…ts for improved clarity and maintainability

…ormatting and commenting out unused scatter series code

…date styles in status.component.scss for better visibility; comment out GitHub repository link in settings.component.html for future reference.

austenstone added 2 commits December 5, 2024 09:59

Refactor status component and enhance API integration; update styles …

ecd5671

…and improve development scripts

Enhance survey and chart components; update titles, add new API endpo…

50c6d9c

…int, and improve data handling

github-advanced-security bot found potential problems Dec 6, 2024

View reviewed changes

Remove unnecessary console log statements across various components a…

4f37849

…nd services for cleaner code

github-advanced-security bot found potential problems Dec 6, 2024

View reviewed changes

backend/src/services/status.service.ts Fixed Show fixed Hide fixed

austenstone added 3 commits December 6, 2024 13:03

Comment out unused parameters and code in database and chart componen…

82d2a26

…ts for improved clarity and maintainability

Refactor HighchartsService to improve code readability by adjusting f…

088c914

…ormatting and commenting out unused scatter series code

Refactor imports in status.service.ts for correct path resolution; up…

5d05b58

…date styles in status.component.scss for better visibility; comment out GitHub repository link in settings.component.html for future reference.

austenstone merged commit f0e48a4 into main Dec 9, 2024
10 of 11 checks passed

austenstone deleted the status branch December 9, 2024 13:43

@@ -2,3 +2,3 @@
             import { Seat } from "../models/copilot.seats.model.js";
-            import { Op, QueryTypes, Sequelize } from 'sequelize';
+            import { Op, Sequelize } from 'sequelize';
             import { components } from "@octokit/openapi-types";

@@ -8,3 +8,3 @@
             import { CopilotSurveyService, Survey } from '../../../services/api/copilot-survey.service';
-            import { forkJoin, Subject, Subscription, takeUntil } from 'rxjs';
+            import { Subject, Subscription, takeUntil } from 'rxjs';
             import { AdoptionChartComponent } from '../copilot-value/adoption-chart/adoption-chart.component';

@@ -76,3 +76,3 @@
               activityTotals?: Record<string, number>;
-              status?: any;
+              status?: { [key: string]: string | number | boolean };
               statuses = [] as {

@@ -15,2 +15,5 @@
             import { StatusComponent } from './status/status.component';
+            interface Installation {
+              repos: { length: number }[];
+            }
@@ -128,3 +131,3 @@
                         title: 'GitHub App',
-                        message: status.installations.reduce((acc: number, i: any) => acc += i.repos.length, 0) + ' repositories',
+                        message: status.installations.reduce((acc: number, i: Installation) => acc += i.repos.length, 0) + ' repositories',
                         status: status.installations.length > 0 ? 'success' : 'error'

@@ -7,3 +7,3 @@
             import { Installation, InstallationsService } from '../../../services/api/installations.service';
-            import { forkJoin, Subject, Subscription, takeUntil } from 'rxjs';
+            import { Subject, Subscription, takeUntil } from 'rxjs';
             import { DashboardCardBarsComponent } from '../copilot-dashboard/dashboard-card/dashboard-card-bars/dashboard-card-bars.component';

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Status #84

Status #84

austenstone commented Dec 6, 2024

github-actions bot commented Dec 6, 2024 •

edited

Loading

Provide additional feedback

Please help us improve GitHub Copilot by sharing more details about this comment.

Provide additional feedback

Please help us improve GitHub Copilot by sharing more details about this comment.

Provide additional feedback

Please help us improve GitHub Copilot by sharing more details about this comment.

Provide additional feedback

Please help us improve GitHub Copilot by sharing more details about this comment.

Provide additional feedback

Please help us improve GitHub Copilot by sharing more details about this comment.

Provide additional feedback

Please help us improve GitHub Copilot by sharing more details about this comment.

Provide additional feedback

Please help us improve GitHub Copilot by sharing more details about this comment.

		@@ -1,4 +1,4 @@
		import { Injectable, OnDestroy } from '@angular/core';
		import { Injectable, OnDestroy, OnInit } from '@angular/core';

@@ -19,2 +19,10 @@
+            export interface StatusResponse2 {
+              // Define the structure of the response here
+              // For example:
+              isSetup: boolean;
+              dbConnected: boolean;
+              installations: InstallationStatus[];
+            }
             export type Installations = Endpoints["GET /app/installations"]["response"]["data"]
@@ -75,3 +83,3 @@
               getStatus2() {
-                return this.http.get<any>(`${serverUrl}/api/status`);
+                return this.http.get<StatusResponse2>(`${serverUrl}/api/status`);
               }

Status #84

Status #84

Conversation

austenstone commented Dec 6, 2024

github-actions bot commented Dec 6, 2024 • edited Loading

Dependency Review

OpenSSF Scorecard

Scanned Files

github-actions bot commented Dec 6, 2024 •

edited

Loading