Update survey titles and labels for clarity: reflect focus on Copilot impact and time savings #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… impact and time savings
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...tend/src/app/main/copilot/copilot-surveys/new-copilot-survey/new-copilot-survey.component.ts
Fixed
Show fixed
Hide fixed
MattG57
commented
Nov 30, 2024
…s, and enhance frontend styles and structure
…' of https://github.com/austenstone/github-value into Nomenclature-for-Developer-Estimates-plus-Form-behavior
| @@ -1,4 +1,4 @@ | |||
| import { HttpClient } from '@angular/common/http'; | |||
| import { HttpClient, HttpParams } from '@angular/common/http'; | |||
Check failure
Code scanning / ESLint
Disallow unused variables Error
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix AI about 2 months ago
To fix the problem, we need to remove the unused HttpParams import from the file frontend/src/app/services/api/copilot-survey.service.ts. This will resolve the ESLint error and clean up the code by eliminating unnecessary imports.
- Locate the import statement on line 1.
- Remove
HttpParamsfrom the import statement.
Suggested changeset
1
frontend/src/app/services/api/copilot-survey.service.ts
| @@ -1,2 +1,2 @@ | ||
| import { HttpClient, HttpParams } from '@angular/common/http'; | ||
| import { HttpClient } from '@angular/common/http'; | ||
| import { Injectable } from '@angular/core'; |
Copilot is powered by AI and may make mistakes. Always verify output.
…d add kudos update functionality
...tend/src/app/main/copilot/copilot-surveys/new-copilot-survey/new-copilot-survey.component.ts
Fixed
Show fixed
Hide fixed
|
|
||
| getMemberByLogin(login: string) { | ||
| return this.http.get<Endpoints["GET /users/{username}"]["response"]["data"]>(`${this.apiUrl}/${login}`).pipe( | ||
| catchError((error) => { |
Check failure
Code scanning / ESLint
Disallow unused variables Error
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix AI about 2 months ago
To fix the problem, we need to remove the unused error variable from the catchError block. This can be done by simply omitting the parameter in the arrow function, as it is not used within the function body. This change will not affect the existing functionality of the code.
Suggested changeset
1
frontend/src/app/services/api/members.service.ts
| @@ -23,3 +23,3 @@ | ||
| return this.http.get<Endpoints["GET /users/{username}"]["response"]["data"]>(`${this.apiUrl}/${login}`).pipe( | ||
| catchError((error) => { | ||
| catchError(() => { | ||
| return throwError(() => new Error('User not found')); |
Copilot is powered by AI and may make mistakes. Always verify output.
… pipe for numeric inputs
…n, modify survey model to streamline kudos property, enhance API service for survey retrieval, and improve frontend layout and styles.
| downstreamProductivity: string; | ||
| } | ||
|
|
||
| interface Metrics { |
Check failure
Code scanning / ESLint
Disallow unused variables Error
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix AI about 2 months ago
To fix the problem, we need to remove the unused Metrics interface from the code. This will resolve the ESLint error and clean up the code by eliminating unnecessary definitions. The change should be made in the file frontend/src/app/main/copilot/value-modeling/value-modeling.component.ts.
Suggested changeset
1
frontend/src/app/main/copilot/value-modeling/value-modeling.component.ts
| @@ -17,7 +17,3 @@ | ||
|
|
||
| interface Metrics { | ||
| current: MetricState; | ||
| target: MetricState; | ||
| max: MetricState; | ||
| } | ||
|
|
||
|
|
Copilot is powered by AI and may make mistakes. Always verify output.
…form labels for clarity
…' of github.com:austenstone/github-value into Nomenclature-for-Developer-Estimates-plus-Form-behavior
…ent to use number formatting directly
Comment on lines
+173
to
+176
| ngOnInit() { | ||
| // this.updateChartData(); | ||
| // this.form.valueChanges.subscribe(() => this.updateChartData()); | ||
| } |
Check failure
Code scanning / ESLint
Disallows declaring empty lifecycle methods Error
…eOptions for improved type safety
austenstone
approved these changes
Dec 6, 2024
MattG57
deleted the
Nomenclature-for-Developer-Estimates-plus-Form-behavior
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.