Fix missing sourceMap in PROD and relative default assets folder #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 7, 2019 12:09
Change loading to load monaco from monaco/min i.o. /monaco
|
Are you using this fix locally? |
miki995
added a commit
to miki995/ngx-monaco-editor-v2
that referenced
this pull request
Aug 2, 2022
miki995
added a commit
to miki995/ngx-monaco-editor-v2
that referenced
this pull request
Aug 3, 2022
|
@here I've a new fork with latest angular 14, ngZone upgrade and fixed production missing assets, have a look, works for my company now: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the base-editor to use default the relative "assets" folder.
Included min-maps from monaco to be exposed as assets.
Changed structure to be /monaco/min & /monaco/min-maps. Base-editor loads from /monaco/min