Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove smart_open. #2

Draft
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Draft

Remove smart_open. #2

wants to merge 1 commit into from

Conversation

atspaeth
Copy link
Owner

Fix #1

@atspaeth
Copy link
Owner Author

Results so far don't seem to have changed the slowness of using smart_open,
and the new method seems a bit less reliable, so maybe the only way to make
this change worth doing is to perform the uploads in a background thread...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Avoid using smart_open
1 participant
@atspaeth