-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance favorite Doctor Screen and add Dark theme #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23nosurrend
added
Progress
task in progress
and removed
Need Review
Requires reviews
labels
May 31, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #120 +/- ##
========================================
Coverage 72.22% 72.22%
========================================
Files 3 3
Lines 18 18
Branches 3 3
========================================
Hits 13 13
Misses 5 5 ☔ View full report in Codecov by Sentry. |
23nosurrend
force-pushed
the
fix-favoriteDoctor-Screen
branch
3 times, most recently
from
June 4, 2024 12:21
9d6a8bb
to
90d804d
Compare
23nosurrend
added
Need Review
Requires reviews
and removed
Progress
task in progress
labels
Jun 4, 2024
23nosurrend
force-pushed
the
fix-favoriteDoctor-Screen
branch
from
June 5, 2024 13:29
90d804d
to
3a5ff81
Compare
23nosurrend
force-pushed
the
fix-favoriteDoctor-Screen
branch
from
June 6, 2024 09:03
3a5ff81
to
fd63998
Compare
Irirwanirira
approved these changes
Jun 6, 2024
Mbabazi12
approved these changes
Jun 6, 2024
mr3nz1
requested review from
mr3nz1
and removed request for
munezeromicha and
Mbabazi12
June 6, 2024 10:55
mr3nz1
approved these changes
Jun 6, 2024
Nkbtemmy
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Enhance UI and Add Dark Theme for Favorite Doctor Screen
Description:
This PR focuses on enhancing the UI and adding a dark theme to the Favorite Doctor Screen. The current implementation requires improvements to ensure a seamless and aesthetically pleasing user experience, especially when switching between themes. Additionally, this PR ensures that the search functionalities respect the dark theme.
Tasks:
Dynamic Theme Handling:
Ensure that the background color and other UI elements adjust dynamically based on the selected theme (light or dark).
Verify that the search bar and results are properly styled for both themes.
Favorite Doctor Layout:
Improve the layout and appearance of favorite doctor items for better readability and visual appeal.
Ensure that all favorite doctor items are well-organized and visually appealing.
Light Theme:
Ensure that the background and text colors provide sufficient contrast for readability.
Verify that the search bar and search results are clearly visible and styled appropriately.
Dark Theme:
ScreenShot