Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance favorite Doctor Screen and add Dark theme #120

Merged
merged 2 commits into from
Jun 6, 2024

Conversation

23nosurrend
Copy link
Collaborator

What does this PR do?

Enhance UI and Add Dark Theme for Favorite Doctor Screen

Description:

This PR focuses on enhancing the UI and adding a dark theme to the Favorite Doctor Screen. The current implementation requires improvements to ensure a seamless and aesthetically pleasing user experience, especially when switching between themes. Additionally, this PR ensures that the search functionalities respect the dark theme.

Tasks:

Dynamic Theme Handling:
Ensure that the background color and other UI elements adjust dynamically based on the selected theme (light or dark).
Verify that the search bar and results are properly styled for both themes.

Favorite Doctor Layout:

Improve the layout and appearance of favorite doctor items for better readability and visual appeal.
Ensure that all favorite doctor items are well-organized and visually appealing.

Light Theme:

Ensure that the background and text colors provide sufficient contrast for readability.
Verify that the search bar and search results are clearly visible and styled appropriately.
Dark Theme:

ScreenShot

Screenshot_20240531_122518_Expo Go
Screenshot_20240531_122222_Expo Go
Screenshot_20240531_122531_Expo Go

@23nosurrend 23nosurrend added Fix A fix to a problem Need Review Requires reviews labels May 31, 2024
@23nosurrend 23nosurrend added this to the Mobile App UI milestone May 31, 2024
@23nosurrend 23nosurrend self-assigned this May 31, 2024
@23nosurrend 23nosurrend linked an issue May 31, 2024 that may be closed by this pull request
@23nosurrend 23nosurrend added Progress task in progress and removed Need Review Requires reviews labels May 31, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jun 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.22%. Comparing base (651efb4) to head (411b4b9).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #120   +/-   ##
========================================
  Coverage    72.22%   72.22%           
========================================
  Files            3        3           
  Lines           18       18           
  Branches         3        3           
========================================
  Hits            13       13           
  Misses           5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@23nosurrend 23nosurrend force-pushed the fix-favoriteDoctor-Screen branch 3 times, most recently from 9d6a8bb to 90d804d Compare June 4, 2024 12:21
@23nosurrend 23nosurrend added Need Review Requires reviews and removed Progress task in progress labels Jun 4, 2024
@23nosurrend 23nosurrend force-pushed the fix-favoriteDoctor-Screen branch from 90d804d to 3a5ff81 Compare June 5, 2024 13:29
@23nosurrend 23nosurrend force-pushed the fix-favoriteDoctor-Screen branch from 3a5ff81 to fd63998 Compare June 6, 2024 09:03
@Mbabazi12 Mbabazi12 requested review from Mbabazi12 and removed request for munezeromicha June 6, 2024 10:40
@mr3nz1 mr3nz1 requested review from mr3nz1 and removed request for munezeromicha and Mbabazi12 June 6, 2024 10:55
@Irirwanirira Irirwanirira removed the Fix A fix to a problem label Jun 6, 2024
@Nkbtemmy Nkbtemmy merged commit d015e1a into develop Jun 6, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Need Review Requires reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix: Fix and Enhance UI for favorite doctors screen
6 participants