Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: fixed socket #91

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Fix: fixed socket #91

merged 1 commit into from
Jul 17, 2024

Conversation

soleil00
Copy link
Collaborator

What doe sthis PR Does

in this PR i have fixed socket and added event for password expire

@soleil00 soleil00 requested a review from teerenzo July 11, 2024 15:26
@soleil00 soleil00 force-pushed the fx-socket4 branch 2 times, most recently from 2414aae to 6c9667e Compare July 12, 2024 14:35
@codecov-commenter
Copy link

codecov-commenter commented Jul 12, 2024

Codecov Report

Attention: Patch coverage is 81.57895% with 28 lines in your changes missing coverage. Please review.

Project coverage is 74.48%. Comparing base (b54207b) to head (6fbe7f0).
Report is 2 commits behind head on dev.

Files Patch % Lines
src/controllers/productControllers.ts 80.76% 19 Missing and 1 partial ⚠️
src/events/handler.ts 71.42% 4 Missing ⚠️
src/controllers/notificationController.ts 33.33% 2 Missing ⚠️
src/jobs/isPasswordExpired.ts 0.00% 1 Missing ⚠️
src/middlewares/verifyToken.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev      #91      +/-   ##
==========================================
+ Coverage   74.07%   74.48%   +0.40%     
==========================================
  Files         126      126              
  Lines        2280     2269      -11     
  Branches      311      294      -17     
==========================================
+ Hits         1689     1690       +1     
+ Misses        570      559      -11     
+ Partials       21       20       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@soleil00 soleil00 force-pushed the fx-socket4 branch 4 times, most recently from ffbd0ff to 8d05c61 Compare July 17, 2024 06:32
Copy link

gitguardian bot commented Jul 17, 2024

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@soleil00 soleil00 force-pushed the fx-socket4 branch 13 times, most recently from a5b2474 to 9e5dacc Compare July 17, 2024 08:38
fix: fixed category fetching allowing all user to fetch availabe catgeories
@teerenzo teerenzo merged commit 9e61a03 into dev Jul 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants