socket fix #73
Merged
socket fix #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soleil00
requested review from
MugemaneBertin2001,
teerenzo,
niyobertin,
Heisjabo and
yvanddniyo
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #73 +/- ##
==========================================
- Coverage 77.66% 77.51% -0.15%
==========================================
Files 120 120
Lines 2100 2104 +4
Branches 285 286 +1
==========================================
Hits 1631 1631
- Misses 457 461 +4
Partials 12 12 ☔ View full report in Codecov by Sentry. |
teerenzo
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what does this PR does
in this PR i have fixed cors error for socket where someone wrongly changed socket allowed origin which unfortunaely led to in app notification feature mulfunctioned
FROM
TO