Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#187658788-feature(Enabling Private Chat functionality): Buyers should be able to select a seller to chat with them about the products #71

Merged
merged 3 commits into from
Jun 3, 2024

Conversation

Jovz19200
Copy link
Collaborator

what does the PR do?

  • It enables the private chat in the application

how to test this PR?

  • After cloning this repo.
  • checkout to my branch ft-private-chat-#187658788
  • RUN npm run migrate
  • npm run dev
  • checkout https://{env}/api/v1/chats to test private chat

@codecov-commenter
Copy link

codecov-commenter commented May 28, 2024

Codecov Report

Attention: Patch coverage is 36.78161% with 110 lines in your changes are missing coverage. Please review.

Project coverage is 74.53%. Comparing base (a5680e8) to head (311597e).

Current head 311597e differs from pull request most recent head e30f331

Please upload reports for the commit e30f331 to get more accurate results.

Files Patch % Lines
src/controllers/privateChatController.ts 15.15% 51 Missing and 5 partials ⚠️
src/services/privateChat.service.ts 21.05% 28 Missing and 2 partials ⚠️
src/config/socketCofing.ts 22.22% 12 Missing and 2 partials ⚠️
src/controllers/userControllers.ts 28.57% 5 Missing ⚠️
src/services/chatServices.ts 0.00% 3 Missing ⚠️
src/services/wishlist.service.ts 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev      #71      +/-   ##
==========================================
- Coverage   77.47%   74.53%   -2.95%     
==========================================
  Files         120      126       +6     
  Lines        2109     2266     +157     
  Branches      285      303      +18     
==========================================
+ Hits         1634     1689      +55     
- Misses        475      556      +81     
- Partials        0       21      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jovz19200 Jovz19200 force-pushed the ft-private-chat-#187658788 branch from 1a39c4f to 5063b09 Compare May 29, 2024 07:56
@Jovz19200 Jovz19200 changed the title feature(Enabling Private Chat functionality): Buyers should be able to select a seller to ask them about the products #187658788-feature(Enabling Private Chat functionality): Buyers should be able to select a seller to ask them about the products May 29, 2024
@Jovz19200 Jovz19200 force-pushed the ft-private-chat-#187658788 branch 4 times, most recently from 8b51b9c to ba69bb8 Compare May 30, 2024 15:14
@Jovz19200 Jovz19200 force-pushed the ft-private-chat-#187658788 branch 3 times, most recently from 569920f to 23c74a5 Compare May 31, 2024 13:36
@Jovz19200 Jovz19200 force-pushed the ft-private-chat-#187658788 branch from 8ce536a to 063ee4b Compare June 2, 2024 20:58
@Jovz19200 Jovz19200 changed the title #187658788-feature(Enabling Private Chat functionality): Buyers should be able to select a seller to ask them about the products #187658788-feature(Enabling Private Chat functionality): Buyers should be able to select a seller to chat with them about the products Jun 3, 2024
Copy link
Collaborator

@soleil00 soleil00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jovz19200 Jovz19200 force-pushed the ft-private-chat-#187658788 branch from 063ee4b to 311597e Compare June 3, 2024 12:01
@Jovz19200 Jovz19200 force-pushed the ft-private-chat-#187658788 branch from e30f331 to 484ed93 Compare June 3, 2024 12:05
@teerenzo teerenzo merged commit 349cc0b into dev Jun 3, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants