Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#187658789 generate fake ads with aws lambda function #69

Merged
merged 1 commit into from
May 29, 2024

Conversation

Heisjabo
Copy link
Collaborator

What does this PR do?

This PR implements fake ads using aws lambda function

Description of Task to be completed?

  • using aws lambda function to generate ads from aliexpress

How should this be manually tested?

  1. Clone the repository.
  2. Checkout to the branch ft-fake-ads-#187658789.
  3. Run npm install to install dependencies.
  4. Run npm run migrate and npm run seed
  5. Run npm run dev to start the development server.
  6. Open a web browser and navigate to the /docs endpoint.
  7. Verify that the Swagger UI loads correctly.
  8. use the endpoint GET /api/v1/products/ads and add a query of a category of products to retrieve

What are the relevant pivotal tracker stories?

Delivers #187658789

@codecov-commenter
Copy link

codecov-commenter commented May 27, 2024

Codecov Report

Attention: Patch coverage is 89.47368% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 77.74%. Comparing base (04225b4) to head (bade730).

Files Patch % Lines
src/controllers/adsController.ts 85.71% 1 Missing ⚠️
src/services/ads.service.ts 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev      #69      +/-   ##
==========================================
- Coverage   78.07%   77.74%   -0.33%     
==========================================
  Files         117      119       +2     
  Lines        2057     2076      +19     
  Branches      280      281       +1     
==========================================
+ Hits         1606     1614       +8     
- Misses        451      462      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@MugemaneBertin2001 MugemaneBertin2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Heisjabo Heisjabo force-pushed the ft-fake-ads-#187658789 branch from 700a42f to 7b875e0 Compare May 28, 2024 17:48
Copy link
Collaborator

@soleil00 soleil00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Heisjabo Heisjabo force-pushed the ft-fake-ads-#187658789 branch from 7b875e0 to c3ee43e Compare May 28, 2024 23:15
- using lambda function to generate ads from aliexpress

Delivers #187658789
@Heisjabo Heisjabo force-pushed the ft-fake-ads-#187658789 branch from c3ee43e to bade730 Compare May 29, 2024 09:02
@teerenzo teerenzo merged commit 1e8164b into dev May 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants