feat(search): Implement the search products #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yvanddniyo
requested review from
dniwemugisha,
MugemaneBertin2001,
teerenzo,
Jovz19200,
Heisjabo and
soleil00
yvanddniyo
force-pushed
the
ft-search-product-#187419190
branch
from
85fc615 to
0514b85
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #46 +/- ##
==========================================
- Coverage 79.65% 79.55% -0.11%
==========================================
Files 64 65 +1
Lines 1057 1115 +58
Branches 149 163 +14
==========================================
+ Hits 842 887 +45
- Misses 215 225 +10
- Partials 0 3 +3 ☔ View full report in Codecov by Sentry. |
yvanddniyo
force-pushed
the
ft-search-product-#187419190
branch
2 times, most recently
from
045c477 to
e201c78
Compare
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 10820488 | Triggered | Generic Password | a01d398 | test/product.test.ts | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Heisjabo
approved these changes
May 8, 2024
Heisjabo
approved these changes
May 8, 2024
teerenzo
requested changes
May 8, 2024
src/docs/products.ts
Outdated
| export const searchParams = { | ||
| properties: { | ||
| type:"params", | ||
| name: { | ||
| type: "string" | ||
| }, | ||
| minPrice: { | ||
| type: "number" | ||
| }, | ||
| maxPrice: { | ||
| type: "number" | ||
| }, | ||
| category: { | ||
| type: "string" | ||
| }, | ||
| } | ||
| } | ||
|
|
||
| export const getProducts = { |
There was a problem hiding this comment.
No, I'm not using it. I forgot to delete
yvanddniyo
force-pushed
the
ft-search-product-#187419190
branch
from
e201c78 to
ee03b6f
Compare
- Seller should allowed to search their own products - other users which are not seller should see all products [Delives #187419190]
yvanddniyo
force-pushed
the
ft-search-product-#187419190
branch
from
ee03b6f to
a01d398
Compare
teerenzo
approved these changes
May 9, 2024
MugemaneBertin2001
pushed a commit
that referenced
this pull request
May 9, 2024
feat(search): Implement the search products
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
This PR focus on searching products where users can search different products depend on their preference and can retrieve precisely products based on their searches.
Description of the PR
How should this be manually tested?
What are the relevant pivotal tracker stories?
[Delivers #187419190]