#187419178 as seller should CRUD products #41
Conversation
niyobertin
requested review from
dniwemugisha,
teerenzo,
Jovz19200,
Heisjabo and
yvanddniyo
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| allowNull: false, | ||
| type: Sequelize.DATE, | ||
| }, | ||
| }); |
There was a problem hiding this comment.
Unrecoverable syntax error. (91% scanned).
| /** @type {import('sequelize-cli').Migration} */ | ||
| module.exports = { | ||
| async up(queryInterface, Sequelize) { | ||
| await queryInterface.createTable('products', { |
There was a problem hiding this comment.
Expected an assignment or function call and instead saw an expression.
Missing semicolon.
| /* eslint-disable @typescript-eslint/no-unused-vars */ | ||
| /** @type {import('sequelize-cli').Migration} */ | ||
| module.exports = { | ||
| async up(queryInterface, Sequelize) { |
There was a problem hiding this comment.
Expected ':' and instead saw 'up'.
Expected '}' to match '{' from line 3 and instead saw '{'.
Missing semicolon.
| allowNull: false, | ||
| type: Sequelize.DATE, | ||
| }, | ||
| }); |
There was a problem hiding this comment.
Unrecoverable syntax error. (91% scanned).
| /** @type {import('sequelize-cli').Migration} */ | ||
| module.exports = { | ||
| async up(queryInterface, Sequelize) { | ||
| await queryInterface.createTable('products', { |
There was a problem hiding this comment.
Expected an assignment or function call and instead saw an expression.
Missing semicolon.
| /* eslint-disable @typescript-eslint/no-unused-vars */ | ||
| /** @type {import('sequelize-cli').Migration} */ | ||
| module.exports = { | ||
| async up(queryInterface, Sequelize) { |
There was a problem hiding this comment.
Expected ':' and instead saw 'up'.
Expected '}' to match '{' from line 3 and instead saw '{'.
Missing semicolon.
niyobertin
force-pushed
the
187419178-ft-products-queries-CRUD
branch
3 times, most recently
from
e560500 to
f81d230
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #41 +/- ##
==========================================
+ Coverage 77.79% 78.30% +0.51%
==========================================
Files 41 56 +15
Lines 563 899 +336
Branches 61 124 +63
==========================================
+ Hits 438 704 +266
- Misses 125 195 +70 ☔ View full report in Codecov by Sentry. |
-ensure that every endpoint related to products is working -ensure that every end pint related to categories is working -all endpoints are documented with swagger -all endpoints are tested with test coverage of 80+ [Delives #187419178]
niyobertin
force-pushed
the
187419178-ft-products-queries-CRUD
branch
from
f81d230 to
e29cbae
Compare
| allowNull: false, | ||
| type: Sequelize.DATE, | ||
| }, | ||
| }); |
There was a problem hiding this comment.
Unrecoverable syntax error. (86% scanned).
| /** @type {import('sequelize-cli').Migration} */ | ||
| module.exports = { | ||
| async up(queryInterface, Sequelize) { | ||
| await queryInterface.createTable('categories', { |
There was a problem hiding this comment.
Expected an assignment or function call and instead saw an expression.
Missing semicolon.
| /* eslint-disable @typescript-eslint/no-unused-vars */ | ||
| /** @type {import('sequelize-cli').Migration} */ | ||
| module.exports = { | ||
| async up(queryInterface, Sequelize) { |
There was a problem hiding this comment.
Expected ':' and instead saw 'up'.
Expected '}' to match '{' from line 3 and instead saw '{'.
Missing semicolon.
What does this PR do?
Have CRUD on products and categories endpoints
Description of Task to be completed?
Have the following end points working
Products endpoints
GET /api/v1/products
GET /api/v1/products/:id
POST /api/v1/products
PATCH /api/v1/products/:id
DELETE /api/v1/products/:id
Categories endpoints
GET /api/v1/categories
GET /api/v1/categories/:id
POST /api/v1/categories/
PATCH /api/v1/categories/:id
DELETE /api/v1/categories/:id
How should this be manually tested?
After cloning this repository,cd into it and run the following commands
using postman or other testing invironment likr thunder client, test every end point above with this header:
_key:_Content-type value:multipart/form-data
To test authentication,add this to the header:Get token from user login endpoint
_key:_Authorization value:JWT TOKEN
NB: you must login in as a seller.
Using swagger documentation , open your brouser and type localhost:PORT/docs
Any background context you want to provide?
By testing above endpoint you start by creating or inserting categories before creating a products and the you create a prduct.
What are the relevant pivotal tracker stories?
#187419178