#23187419173 - fx:fixed Two Factor Authentication for Sellers #35

soleil00 · 2024-04-29T11:32:56Z

What does this PR do?

This PR sets up Two Factor Authentication for Sellers

Description of Task to be completed?

-GIVEN there is a request to log in a user to the website
WHEN 2FA is enabled on the particular user
THEN Further request for a 2FA token should be requested and once the token is received and validated, the user is allowed to log in.

How should this be manually tested?

checkout this branch and run app
regiter new user with extra filed isMerchant field set to true
then login with email and password
there u will see magic happen u will get message that verification token has been sent to ur email
go there open email and copy token and send them in req.body to specified endpoint in body /api/v1/users/2fa-verify

pivotal tracker id ----> #23187419173

Screenshots

codecov-commenter · 2024-04-29T12:52:39Z

Codecov Report

Attention: Patch coverage is 57.74648% with 30 lines in your changes are missing coverage. Please review.

Project coverage is 78.26%. Comparing base (dc505f3) to head (e77f265).

Files	Patch %	Lines
src/controllers/userControllers.ts	48.48%	16 Missing and 1 partial ⚠️
src/middlewares/isTokenFound.ts	18.18%	9 Missing ⚠️
src/services/user.service.ts	62.50%	3 Missing ⚠️
src/services/mail.service.ts	87.50%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##              dev      #35      +/-   ##
==========================================
- Coverage   83.45%   78.26%   -5.20%     
==========================================
  Files          23       24       +1     
  Lines         278      299      +21     
  Branches       33       40       +7     
==========================================
+ Hits          232      234       +2     
- Misses         46       64      +18     
- Partials        0        1       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…code

hound · 2024-04-29T13:47:25Z

src/sequelize/migrations/20240422124749-add-role-field-to-user.js

+    await queryInterface.addColumn("users", "role", {
+      type: Sequelize.ARRAY(Sequelize.STRING),
+      defaultValue: ["buyer"],
+    });


Unrecoverable syntax error. (56% scanned).

hound · 2024-04-29T13:47:25Z

src/sequelize/migrations/20240422124749-add-role-field-to-user.js

+/** @type {import('sequelize-cli').Migration} */
+module.exports = {
+  async up(queryInterface, Sequelize) {
+    await queryInterface.addColumn("users", "role", {


Expected an assignment or function call and instead saw an expression.
Missing semicolon.

hound · 2024-04-29T13:47:25Z

src/sequelize/migrations/20240422124749-add-role-field-to-user.js

+
+/** @type {import('sequelize-cli').Migration} */
+module.exports = {
+  async up(queryInterface, Sequelize) {


Expected ':' and instead saw 'up'.
Expected '}' to match '{' from line 4 and instead saw '{'.
Missing semicolon.

hound · 2024-04-29T13:47:25Z

src/sequelize/migrations/20240422124749-add-role-field-to-user.js

@@ -0,0 +1,15 @@
+"use strict";


Use the function form of "use strict".

hound · 2024-04-29T13:47:25Z

src/sequelize/migrations/20240429064011-add-token-model.js

+        allowNull: false,
+        type: Sequelize.DATE,
+      },
+    });


Unrecoverable syntax error. (76% scanned).

hound · 2024-04-29T13:47:25Z

src/sequelize/migrations/20240429064011-add-token-model.js

+
+module.exports = {
+  async up(queryInterface, Sequelize) {
+    await queryInterface.createTable("tokens", {


Expected an assignment or function call and instead saw an expression.
Missing semicolon.

hound · 2024-04-29T13:47:25Z

src/sequelize/migrations/20240429064011-add-token-model.js

+"use strict";
+
+module.exports = {
+  async up(queryInterface, Sequelize) {


Expected ':' and instead saw 'up'.
Expected '}' to match '{' from line 3 and instead saw '{'.
Missing semicolon.

hound · 2024-04-29T13:47:25Z

src/sequelize/migrations/20240429064011-add-token-model.js

@@ -0,0 +1,29 @@
+"use strict";


Use the function form of "use strict".

hound · 2024-04-29T13:47:25Z

src/sequelize/migrations/20240422124749-add-role-field-to-user.js

+    await queryInterface.addColumn("users", "role", {
+      type: Sequelize.ARRAY(Sequelize.STRING),
+      defaultValue: ["buyer"],
+    });


Unrecoverable syntax error. (56% scanned).

hound · 2024-04-29T13:47:25Z

src/sequelize/migrations/20240422124749-add-role-field-to-user.js

+/** @type {import('sequelize-cli').Migration} */
+module.exports = {
+  async up(queryInterface, Sequelize) {
+    await queryInterface.addColumn("users", "role", {


Expected an assignment or function call and instead saw an expression.
Missing semicolon.

hound · 2024-04-29T13:47:25Z

src/sequelize/migrations/20240422124749-add-role-field-to-user.js

+
+/** @type {import('sequelize-cli').Migration} */
+module.exports = {
+  async up(queryInterface, Sequelize) {


Expected ':' and instead saw 'up'.
Expected '}' to match '{' from line 4 and instead saw '{'.
Missing semicolon.

hound · 2024-04-29T13:47:25Z

src/sequelize/migrations/20240422124749-add-role-field-to-user.js

@@ -0,0 +1,15 @@
+"use strict";


Use the function form of "use strict".

hound · 2024-04-29T13:47:25Z

src/sequelize/migrations/20240422124749-add-role-field-to-user.js

+    await queryInterface.addColumn("users", "role", {
+      type: Sequelize.ARRAY(Sequelize.STRING),
+      defaultValue: ["buyer"],
+    });


Unrecoverable syntax error. (56% scanned).

hound · 2024-04-29T13:47:25Z

src/sequelize/migrations/20240422124749-add-role-field-to-user.js

+/** @type {import('sequelize-cli').Migration} */
+module.exports = {
+  async up(queryInterface, Sequelize) {
+    await queryInterface.addColumn("users", "role", {


Expected an assignment or function call and instead saw an expression.
Missing semicolon.

hound · 2024-04-29T13:47:25Z

src/sequelize/migrations/20240422124749-add-role-field-to-user.js

+
+/** @type {import('sequelize-cli').Migration} */
+module.exports = {
+  async up(queryInterface, Sequelize) {


Expected ':' and instead saw 'up'.
Expected '}' to match '{' from line 4 and instead saw '{'.
Missing semicolon.

hound · 2024-04-29T13:47:25Z

src/sequelize/migrations/20240422124749-add-role-field-to-user.js

@@ -0,0 +1,15 @@
+"use strict";


Use the function form of "use strict".

hound · 2024-04-29T13:47:25Z

src/sequelize/migrations/20240429064011-add-token-model.js

+        allowNull: false,
+        type: Sequelize.DATE,
+      },
+    });


Unrecoverable syntax error. (76% scanned).

hound · 2024-04-29T13:47:25Z

src/sequelize/migrations/20240429064011-add-token-model.js

@@ -0,0 +1,29 @@
+"use strict";


Use the function form of "use strict".

hound · 2024-04-29T13:47:26Z

src/sequelize/migrations/20240429093200-delete-isMechnat-filed.js

+module.exports = {
+  async up(queryInterface, Sequelize) {
+    await queryInterface.removeColumn("users", "twoFAEnabled");
+    await queryInterface.removeColumn("users", "isMerchant");


Expected an assignment or function call and instead saw an expression.
Missing semicolon.
Unrecoverable syntax error. (46% scanned).

hound · 2024-04-29T13:47:26Z

src/sequelize/migrations/20240429093200-delete-isMechnat-filed.js

+/** @type {import('sequelize-cli').Migration} */
+module.exports = {
+  async up(queryInterface, Sequelize) {
+    await queryInterface.removeColumn("users", "twoFAEnabled");


Expected an assignment or function call and instead saw an expression.
Missing semicolon.

hound · 2024-04-29T13:47:26Z

src/sequelize/migrations/20240429093200-delete-isMechnat-filed.js

+
+/** @type {import('sequelize-cli').Migration} */
+module.exports = {
+  async up(queryInterface, Sequelize) {


Expected ':' and instead saw 'up'.
Expected '}' to match '{' from line 4 and instead saw '{'.
Missing semicolon.

hound · 2024-04-29T13:47:26Z

src/sequelize/migrations/20240429093200-delete-isMechnat-filed.js

@@ -0,0 +1,14 @@
+"use strict";


Use the function form of "use strict".

#23187419173 - fx:fixed Two Factor Authentication for Sellers

soleil00 requested review from dniwemugisha, MugemaneBertin2001, teerenzo, niyobertin, Jovz19200, Heisjabo and yvanddniyo April 29, 2024 11:32

soleil00 force-pushed the fx-2f-authentication-#187419173 branch from bbee54a to fcff1e3 Compare April 29, 2024 12:38

soleil00 added the READY FOR REVIEW label Apr 29, 2024

soleil00 changed the title ~~#23187419173 - fx:fixed up Two Factor Authentication for Sellers~~ #23187419173 - fx:fixed Two Factor Authentication for Sellers Apr 29, 2024

fix: fixed 2fa implemetation by replacing verification link with otp …

e77f265

…code

soleil00 force-pushed the fx-2f-authentication-#187419173 branch from fcff1e3 to e77f265 Compare April 29, 2024 13:47

hound bot reviewed Apr 29, 2024

View reviewed changes

teerenzo approved these changes Apr 29, 2024

View reviewed changes

teerenzo merged commit fb51f5b into dev Apr 29, 2024
3 checks passed

niyobertin pushed a commit that referenced this pull request Apr 29, 2024

Merge pull request #35 from atlp-rwanda/fx-2f-authentication-#187419173

d5dba7b

#23187419173 - fx:fixed Two Factor Authentication for Sellers

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#23187419173 - fx:fixed Two Factor Authentication for Sellers #35

#23187419173 - fx:fixed Two Factor Authentication for Sellers #35

soleil00 commented Apr 29, 2024

codecov-commenter commented Apr 29, 2024 •

edited

Loading

hound bot Apr 29, 2024

hound bot Apr 29, 2024

hound bot Apr 29, 2024

hound bot Apr 29, 2024

hound bot Apr 29, 2024

hound bot Apr 29, 2024

hound bot Apr 29, 2024

hound bot Apr 29, 2024

hound bot Apr 29, 2024

hound bot Apr 29, 2024

hound bot Apr 29, 2024

hound bot Apr 29, 2024

hound bot Apr 29, 2024

hound bot Apr 29, 2024

hound bot Apr 29, 2024

hound bot Apr 29, 2024

hound bot Apr 29, 2024

hound bot Apr 29, 2024

hound bot Apr 29, 2024

hound bot Apr 29, 2024

hound bot Apr 29, 2024

hound bot Apr 29, 2024

#23187419173 - fx:fixed Two Factor Authentication for Sellers #35

#23187419173 - fx:fixed Two Factor Authentication for Sellers #35

Conversation

soleil00 commented Apr 29, 2024

What does this PR do?

Description of Task to be completed?

How should this be manually tested?

pivotal tracker id ----> #23187419173

Screenshots

codecov-commenter commented Apr 29, 2024 • edited Loading

Codecov Report

hound bot Apr 29, 2024

Choose a reason for hiding this comment

hound bot Apr 29, 2024

Choose a reason for hiding this comment

hound bot Apr 29, 2024

Choose a reason for hiding this comment

hound bot Apr 29, 2024

Choose a reason for hiding this comment

hound bot Apr 29, 2024

Choose a reason for hiding this comment

hound bot Apr 29, 2024

Choose a reason for hiding this comment

hound bot Apr 29, 2024

Choose a reason for hiding this comment

hound bot Apr 29, 2024

Choose a reason for hiding this comment

hound bot Apr 29, 2024

Choose a reason for hiding this comment

hound bot Apr 29, 2024

Choose a reason for hiding this comment

hound bot Apr 29, 2024

Choose a reason for hiding this comment

hound bot Apr 29, 2024

Choose a reason for hiding this comment

hound bot Apr 29, 2024

Choose a reason for hiding this comment

hound bot Apr 29, 2024

Choose a reason for hiding this comment

hound bot Apr 29, 2024

Choose a reason for hiding this comment

hound bot Apr 29, 2024

Choose a reason for hiding this comment

hound bot Apr 29, 2024

Choose a reason for hiding this comment

hound bot Apr 29, 2024

Choose a reason for hiding this comment

hound bot Apr 29, 2024

Choose a reason for hiding this comment

hound bot Apr 29, 2024

Choose a reason for hiding this comment

hound bot Apr 29, 2024

Choose a reason for hiding this comment

hound bot Apr 29, 2024

Choose a reason for hiding this comment

codecov-commenter commented Apr 29, 2024 •

edited

Loading