-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#187419174 User should be able to update their password #29
Conversation
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
10538571 | Triggered | Generic Password | b8f2110 | test/user.test.ts | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
9dcbcc8
to
2a5c5d2
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #29 +/- ##
==========================================
+ Coverage 85.80% 89.20% +3.39%
==========================================
Files 16 18 +2
Lines 162 213 +51
Branches 18 28 +10
==========================================
+ Hits 139 190 +51
Misses 23 23 ☔ View full report in Codecov by Sentry. |
96ba6ae
to
4581741
Compare
4581741
to
e0fc176
Compare
- Implement the feature to allow users update their password - Added validation check for old password, new password and confirm password - hash the new password before updating - documented the feature using swagger [Delivers #187419174]
e0fc176
to
b8f2110
Compare
What does this PR do?
This PR implements update password feature
Description of Task to be completed?
How should this be manually tested?
ft-passwordupdate-#187419174
.npm install
to install dependencies.npm run dev
to start the development server./docs
endpoint (e.g.,http://localhost:PORT/docs
)./api/v1/users/passwordupdate
and verify that updating password is working.What are the relevant pivotal tracker stories?
[Delivers #187419174]