Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#187419174 User should be able to update their password #29

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

Heisjabo
Copy link
Collaborator

What does this PR do?

This PR implements update password feature

Description of Task to be completed?

  • Implement the feature to allow users update their password
  • Added validation check for old password, new password and confirm password
  • hash the new password before updating
  • documented the feature using swagger

How should this be manually tested?

  1. Clone the repository.
  2. Checkout to the branch ft-passwordupdate-#187419174.
  3. Run npm install to install dependencies.
  4. Run npm run dev to start the development server.
  5. Open a web browser and navigate to the /docs endpoint (e.g., http://localhost:PORT/docs).
  6. Verify that the Swagger UI loads correctly.
  7. First authorize by logging in any user and use the token provided
  8. Explore the endpoint PUT on /api/v1/users/passwordupdate and verify that updating password is working.

What are the relevant pivotal tracker stories?

[Delivers #187419174]

Copy link

gitguardian bot commented Apr 25, 2024

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
10538571 Triggered Generic Password b8f2110 test/user.test.ts View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@Heisjabo Heisjabo force-pushed the ft-passwordupdate-#187419174 branch from 9dcbcc8 to 2a5c5d2 Compare April 25, 2024 11:07
@codecov-commenter
Copy link

codecov-commenter commented Apr 25, 2024

Codecov Report

Attention: Patch coverage is 90.16393% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 89.20%. Comparing base (ac7da2f) to head (b8f2110).

Files Patch % Lines
src/controllers/userControllers.ts 85.71% 3 Missing ⚠️
src/middlewares/isLoggedIn.ts 85.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev      #29      +/-   ##
==========================================
+ Coverage   85.80%   89.20%   +3.39%     
==========================================
  Files          16       18       +2     
  Lines         162      213      +51     
  Branches       18       28      +10     
==========================================
+ Hits          139      190      +51     
  Misses         23       23              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Heisjabo Heisjabo force-pushed the ft-passwordupdate-#187419174 branch 2 times, most recently from 96ba6ae to 4581741 Compare April 25, 2024 17:37
@Heisjabo Heisjabo requested a review from dniwemugisha April 25, 2024 17:43
@Heisjabo Heisjabo force-pushed the ft-passwordupdate-#187419174 branch from 4581741 to e0fc176 Compare April 25, 2024 18:31
@Heisjabo Heisjabo requested a review from niyobertin April 25, 2024 19:13
   - Implement the feature to allow users update their password
   - Added validation check for old password, new password and confirm
     password
   - hash the new password before updating
   - documented the feature using swagger

[Delivers #187419174]
@Heisjabo Heisjabo force-pushed the ft-passwordupdate-#187419174 branch from e0fc176 to b8f2110 Compare April 25, 2024 22:33
@teerenzo teerenzo merged commit bd87282 into dev Apr 25, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants