feat(sign up): implement users sign up #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- user can be to sign up using name, username, email, and password. - user can't be able to sign up twice using same email. [Delivers #187431242]
yvanddniyo
requested review from
dniwemugisha,
teerenzo,
niyobertin and
Heisjabo
|
your branch ahs conflict did u forget to pull?? |
yvanddniyo
force-pushed
the
ft-user-signup-#187431242
branch
2 times, most recently
from
d7fb1a0 to
fbba50d
Compare
niyobertin
approved these changes
Apr 18, 2024
teerenzo
requested changes
Apr 18, 2024
src/sequelize/config/config.js
Outdated
Comment on lines
7
to
13
| dialect: "postgres", | ||
| dialectOptions: { | ||
| ssl: { | ||
| require: true, | ||
| rejectUnauthorized: false, | ||
| }, | ||
| }, |
There was a problem hiding this comment.
do you think this can allow us to use local database
There was a problem hiding this comment.
This allow us to connect to the deployed Database so we are no longer use local database. we're using the deployed one.
src/utils/server.ts
Outdated
| @@ -1,6 +1,7 @@ | |||
| import express from "express"; | |||
| import cors from "cors"; | |||
| import appROutes from "../routes"; | |||
| import userRoutes from "../routes/userRoutes"; | |||
|
work also on your PR naming conversion |
yvanddniyo
force-pushed
the
ft-user-signup-#187431242
branch
from
fbba50d to
76e7975
Compare
|
testing are failing on CI/CD |
yvanddniyo
force-pushed
the
ft-user-signup-#187431242
branch
from
76e7975 to
87cfeb7
Compare
soleil00
requested changes
Apr 18, 2024
package.json
Outdated
| @@ -11,11 +11,13 @@ | |||
| "seed": "npx sequelize-cli db:seed:all", | |||
| "lint": "npx eslint .", | |||
| "lint:fix": "npx eslint --fix .", | |||
| "test": "cross-env NODE_ENV=test jest --detectOpenHandles --coverage" | |||
There was a problem hiding this comment.
bring back cross-env NODE_ENV=test
src/sequelize/config/config.js
Outdated
| @@ -7,11 +7,18 @@ module.exports = { | |||
| dialect: "postgres", | |||
| }, | |||
| test: { | |||
| url: process.env.TEST_DB, | |||
| url: process.env.TEST_DB_CONNECTION, | |||
There was a problem hiding this comment.
remove TEST_DB_CONNECTION instead use TEST_DB
src/utils/env.ts
Outdated
| @@ -4,5 +4,5 @@ dotenv.config(); | |||
| export const env = { | |||
| port: process.env.PORT || 3000, | |||
| db_url: process.env.DB_CONNECTION as string, | |||
| test_db_url: process.env.TEST_DB as string, | |||
| test_db_url: process.env.TEST_DB_CONNECTION as string, | |||
There was a problem hiding this comment.
same issue remove TEST_DB_CONNECTION use TEST_DB
yvanddniyo
force-pushed
the
ft-user-signup-#187431242
branch
from
87cfeb7 to
90bf557
Compare
…o ft-user-signup-#187431242
yvanddniyo
force-pushed
the
ft-user-signup-#187431242
branch
from
90bf557 to
22a0bc3
Compare
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
Heisjabo
approved these changes
Apr 18, 2024
soleil00
approved these changes
Apr 18, 2024
teerenzo
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This pull request addresses the implementation of a sign-up method utilizing PostgreSQL as the backend database. The sign-up process allows new users to register for an account within the system.
Description of Task to be completed?
Here are the endpoint working:
How should this be manually tested?
What are the relevant pivotal tracker stories?
#187431242
Screenshot