Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save interfaces to the settings object, and try to restore on app load. #18

Merged
merged 13 commits into from
Jun 10, 2024

Conversation

petero-dk
Copy link
Contributor

That way connections for interfaces that will not be found by lookup, will restart on app load. I have this problem, and I have seen other people on the forum with this problem.

@petero-dk
Copy link
Contributor Author

@ttherbrink I was not able to assign you as a reviewer, I think this is done. It solves the issue on having interfaces that does not respond to the UDP lookup. So when I manually add it to a device (which works just fine now) it will auto try to reconnect on startup.

It will not fix EVERY issue, if the interface changes ip after restart then it will not work.

For now this would allow people with a knx setup that does not function on UDP broadcast to set a static ip to their device and have it work very stable.

@ttherbrink ttherbrink self-requested a review June 4, 2024 08:18
@ttherbrink ttherbrink self-assigned this Jun 4, 2024
@ttherbrink ttherbrink added the bug Something isn't working label Jun 4, 2024
@petero-dk
Copy link
Contributor Author

I will just pause and breathe for a day or two, because switching branches that start depending on the cleanup, and the small changes in this PR is getting a little crazy. Do you have any idea on how long time PR's like this one and #17 would take for you to review and approve?

Thank you for lettings us contribute.

Copy link
Contributor

@ttherbrink ttherbrink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality seems to be working. The error cases might occur when all the KNX interfaces are offline.

@petero-dk
Copy link
Contributor Author

Functionality seems to be working. The error cases might occur when all the KNX interfaces are offline.

It should at least not fail more than previously now. I added error handling to that part. If all interfaces are offline, there is not much to do.

@petero-dk
Copy link
Contributor Author

❤️

@ttherbrink ttherbrink merged commit 9b05993 into athombv:master Jun 10, 2024
@petero-dk petero-dk deleted the clean/bug/startconnection branch June 10, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging this pull request may close these issues.

3 participants