Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change container metadata to use CONTAINER_APP_REPLICA_NAME #2099

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

marioleed
Copy link
Contributor

Replace environment variable HOSTNAME with CONTAINER_APP_REPLICA_NAME.

Description

In new ACA Environment with workload profiles, using the Consumption profile, HOSTNAME does not appear to exist as an environment variable anymore - thus the application cannot start. However, the env variable CONTAINER_APP_REPLICA_NAME exists in both classic ACA Environment (Consumption) and in new workload profiles (Dedicated + Consumption). So this change should be backwards compatible as well.

Also, it makes more sense in this context and uses the same standard as the other Container App metadata env variables that are fetched.

Purpose

This pull request is a:

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Replace environment variable HOSTNAME with CONTAINER_APP_REPLICA_NAME.
@CLAassistant
Copy link

CLAassistant commented Feb 21, 2024

CLA assistant check
All committers have signed the CLA.

@rogeralsing rogeralsing merged commit c721e27 into asynkron:dev Feb 21, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants