Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cmake and format #1

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Add cmake and format #1

wants to merge 15 commits into from

Conversation

HenryHeffan
Copy link
Collaborator

The old build system should still work too!

@HenryHeffan HenryHeffan requested a review from rmanohar January 17, 2022 16:13
@HenryHeffan
Copy link
Collaborator Author

This cleanup looks good to me. I haven't messed around with the .cc file that much in terms of logic, so there is more cleanup to do there. The new interface is much clearer. The old build system and old interface still exists.

@olerichter
Copy link
Member

olerichter commented Jan 19, 2022

If Rajit does not look at it before, I can have a peek on the weekend if you want, I sadly swamped with other stuff before.

@rmanohar
Copy link
Member

Thanks @olerichter that would be very helpful. I won't be able to look at this for quite a few days.

@HenryHeffan
Copy link
Collaborator Author

@olerichter @rmanohar I dont really need any feedback. I just wanted to let professor manohar know this existed before I merged it. Also, this is still a work in progress. Im going to test (at least most of it) fairly heavily because im using this branch in the chp-optimize repository

@olerichter
Copy link
Member

ok, let me in case you do when its ready,
thanks for the effort!
i am sure you are aware and you possibly already did, it would be good before merging if we adapt the example to your new interfaces (so people know how to use it), and double check if it still works in contention with exproptcommertial in chp2prs as well as with dflow (and i think there might be one more programm)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants