Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sphinxdev ci #77

Merged
merged 4 commits into from
Feb 3, 2025
Merged

Fix sphinxdev ci #77

merged 4 commits into from
Feb 3, 2025

Conversation

pllim
Copy link
Member

@pllim pllim commented Feb 3, 2025

Fix #76

@pllim pllim added the bug Something isn't working label Feb 3, 2025
@pllim pllim added this to the v1.9.2 milestone Feb 3, 2025
@pllim
Copy link
Member Author

pllim commented Feb 3, 2025

Okay... looks like sphinxdev flipped something and that flip isn't backward compatible.

@pllim pllim marked this pull request as ready for review February 3, 2025 19:03
@pllim pllim requested a review from bsipocz February 3, 2025 19:03
@pllim pllim mentioned this pull request Feb 3, 2025
Merged
bsipocz
bsipocz approved these changes Feb 3, 2025
View reviewed changes
Copy link
Member

@bsipocz bsipocz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

As I look at it, the CI matrix is a bit outdated, too, in case you have energy to push a touch-up.

@pllim
Copy link
Member Author

pllim commented Feb 3, 2025

Re: CI -- Do we want to bump minversions? If so, maybe cleaner as follow up PR. Thanks!

@bsipocz bsipocz merged commit f593235 into astropy:main Feb 3, 2025
9 checks passed
@bsipocz
Copy link
Member

bsipocz commented Feb 3, 2025

Gently bumping sounds good. E.g. bump to >=3.9; then release. Or release, bump, release.

@pllim pllim deleted the fix-sphinxdev-ci branch February 3, 2025 19:27
@pllim pllim mentioned this pull request Feb 3, 2025
Merged
@pllim
Copy link
Member Author

pllim commented Feb 3, 2025

Not sure if I did it gently or not but see #78 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsipocz bsipocz bsipocz approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v1.9.2
Development

Successfully merging this pull request may close these issues.

TST: The config value graphviz_dot_args has type list, defaults to tuple
2 participants
@pllim @bsipocz