Add support for numpy 2 #1114
Merged
Add support for numpy 2 #1114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update numpy version requirements for build and install * Replace all `int_t` with `int64_t` * Replace `string_` with `bytes_` and `unicode_` with `str_`
aphearin
reviewed
Jan 27, 2025
| @@ -51,8 +51,8 @@ markers = ["slow", "installation_test"] | |||
| requires = ["setuptools>=42.0.0", | |||
| "setuptools_scm", | |||
| "wheel", | |||
| "oldest-supported-numpy", | |||
There was a problem hiding this comment.
@bsipocz this PR led by @AlanPearl establishes compatibility between halotools and numpy 2.0. However, I'm not sure about this particular line of code because I never really understood what using oldest-supported-numpy did. But this PR fails unless this line is changed to numpy>=2.0.
On a possibly related note, I'm also not sure whether any additional changes need to be made in order to properly use extension-helpers in the right way.
|
This PR also implements |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request brings halotools up to date with numpy 2 to bring #1084 to a close. Build system now requires numpy>=2, which compiles code compatible with both numpy 1 and 2.
Edit: Might still need to replace
oldest-supported-numpywithnumpy>=2here?