TST: pin numpy<2 for tests with old astroscrappy #830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neutrinoceros
commented
Jun 19, 2024
| @@ -38,7 +38,7 @@ deps = | |||
| numpy126: numpy==1.26.* | |||
|
|
|||
| astroscrappy11: astroscrappy==1.1.* | |||
| astroscrappy10: astroscrappy==1.0.* | |||
There was a problem hiding this comment.
I'm also removing the astropyscrappy10 env as it doesn't seem to be used in CI, but obviously I'm happy to revert this if undesired.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #830 +/- ##
==========================================
- Coverage 97.62% 97.61% -0.01%
==========================================
Files 9 9
Lines 1388 1383 -5
==========================================
- Hits 1355 1350 -5
Misses 33 33 ☔ View full report in Codecov by Sentry. |
|
Thanks, @neutrinoceros! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed CI was broken since numpy 2.0 was released: example logs
This should address it.